Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419866
| From | Masami Hiramatsu <mhiramat@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH perf/core v10 10/23] perf probe: Remove caches when --cache is given |
| Date | 2016-06-11 03:20 +0200 |
| Message-ID | <rIFKF-4QS-3@gated-at.bofh.it> (permalink) |
| References | <rHHYe-6M4-17@gated-at.bofh.it> <rHI7U-6Pu-15@gated-at.bofh.it> <rI985-7ym-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 9 Jun 2016 11:28:28 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > diff --git a/tools/perf/util/probe-file.c b/tools/perf/util/probe-file.c
> > index a6d4a67..f687607 100644
> > --- a/tools/perf/util/probe-file.c
> > +++ b/tools/perf/util/probe-file.c
> > @@ -660,19 +660,39 @@ out:
> > return ret;
> > }
> >
> > +static bool probe_cache_entry__compare(struct probe_cache_entry *entry,
> > + struct strfilter *filter)
> > +{
> > + char buf[128], *ptr = entry->spev;
> > +
> > + if (entry->pev.event) {
> > + snprintf(buf, 128, "%s:%s", entry->pev.group, entry->pev.event);
> > + ptr = buf;
> > + }
> > + return strfilter__compare(filter, ptr);
> > +}
> > +
> > +int probe_cache__remove_entries(struct probe_cache *pcache,
> > + struct strfilter *filter)
> > +{
> > + struct probe_cache_entry *entry, *tmp;
> > +
> > + list_for_each_entry_safe(entry, tmp, &pcache->list, list) {
>
> so here you used the preferred idiom, i.e. using
> list_for_each_entry_safe(), once you stop doing the list removal at the
> list entry destructor, it gets the good old boring usual idiom, please
> do that.
OK, I see.
>
> Also please consider renaming perf_cache__remove_entries() to
> perf_cache__filter_purge(), as it doesn't simply remove entries, it
> purges them (that is, remove an entry and delete it), and only if the
> entry got filtered.
OK, such advice about naming helps me a lot :)
Thank you!
--
Masami Hiramatsu <mhiramat@kernel.org>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH perf/core v10 00/23] perf-probe --cache and SDT support Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:30 +0200
[PATCH perf/core v10 02/23] perf-probe: Fix to add NULL check for strndup Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:30 +0200
[tip:perf/core] perf probe: Fix to add NULL check for strndup tip-bot for Masami Hiramatsu <tipbot@zytor.com> - 2016-06-16 10:40 +0200
[PATCH perf/core v10 05/23] perf probe: Recover and export synthesize_perf_probe_point() Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[tip:perf/core] perf probe: Uncomment and export synthesize_perf_probe_point() tip-bot for Masami Hiramatsu <tipbot@zytor.com> - 2016-06-16 10:40 +0200
[PATCH perf/core v10 14/23] perf probe: Accept %sdt and %cached event name Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 18/23] perf probe: Allow wildcard for cached events Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 22/23] perf build: Add sdt feature detection Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 15/23] perf-list: Show SDT and pre-cached events Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 10/23] perf probe: Remove caches when --cache is given Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
Re: [PATCH perf/core v10 10/23] perf probe: Remove caches when --cache is given Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-09 16:30 +0200
Re: [PATCH perf/core v10 10/23] perf probe: Remove caches when --cache is given Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-11 03:20 +0200
[PATCH perf/core v10 09/23] perf probe: Show all cached probes Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
Re: [PATCH perf/core v10 09/23] perf probe: Show all cached probes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-09 16:30 +0200
Re: [PATCH perf/core v10 09/23] perf probe: Show all cached probes Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-11 02:30 +0200
Re: [PATCH perf/core v10 09/23] perf probe: Show all cached probes Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-12 05:30 +0200
[PATCH perf/core v10 08/23] perf probe: Use cache entry if possible Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 12/23] perf probe: Add group name support Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 11/23] perf/sdt: ELF support for SDT Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 04/23] perf probe: Add perf_probe_event__copy() Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[tip:perf/core] perf probe: Add perf_probe_event__copy() tip-bot for Masami Hiramatsu <tipbot@zytor.com> - 2016-06-16 10:40 +0200
[PATCH perf/core v10 21/23] perf probe: Support a special SDT probe format Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 16/23] perf-list: Skip SDTs placed in invalid binaries Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 13/23] perf buildid-cache: Scan and import user SDT events to probe cache Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 17/23] perf: probe-cache: Add for_each_probe_cache_entry() wrapper Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 23/23] perf-test: Add a test case for SDT event Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 19/23] perf probe: Search SDT/cached event from all probe caches Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 20/23] perf probe: Support @BUILDID or @FILE suffix for SDT events Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
[PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
Re: [PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-09 16:20 +0200
Re: [PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-11 01:40 +0200
[PATCH perf/core v10 06/23] perf probe-file: Introduce perf_cache interfaces Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 11:40 +0200
Re: [PATCH perf/core v10 06/23] perf probe-file: Introduce perf_cache interfaces Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-06-09 16:20 +0200
Re: [PATCH perf/core v10 06/23] perf probe-file: Introduce perf_cache interfaces Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-11 00:20 +0200
[PATCH perf/core v10 23/23] perf-test: Add a test case for SDT event Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 13:20 +0200
Re: [PATCH perf/core v10 00/23] perf-probe --cache and SDT support Masami Hiramatsu <masami.hiramatsu@gmail.com> - 2016-06-08 13:20 +0200
[PATCH perf/core v10 22/23] perf build: Add sdt feature detection Masami Hiramatsu <mhiramat@kernel.org> - 2016-06-08 13:20 +0200
csiph-web