Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1419808

Re: [PATCH] ARM: bcm2835: remove unused __packet

From Kevin Hilman <khilman@baylibre.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: bcm2835: remove unused __packet
Date 2016-06-11 00:20 +0200
Message-ID <rICWv-2P1-59@gated-at.bofh.it> (permalink)
References <rHtix-5Fq-1@gated-at.bofh.it> <rHvX4-7lS-3@gated-at.bofh.it>
Organization BayLibre

Show all headers | View raw


Eric Anholt <eric@anholt.net> writes:

> Ben Dooks <ben.dooks@codethink.co.uk> writes:
>
>> The driver defines a variable called __packet but then never
>> uses it, and does not export it for others to use either. Fix
>> the warning about undeclared variable by removing it.
>>
>> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> PM folks: I'd be happy to see this go through your trees, but either way
> is fine with me.

Since this is in drivers/soc, just include it in your cleanup branch for
arm-soc.

Kevin

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: bcm2835: remove unused __packet Ben Dooks <ben.dooks@codethink.co.uk> - 2016-06-07 19:50 +0200
  Re: [PATCH] ARM: bcm2835: remove unused __packet Eric Anholt <eric@anholt.net> - 2016-06-07 22:40 +0200
    Re: [PATCH] ARM: bcm2835: remove unused __packet Kevin Hilman <khilman@baylibre.com> - 2016-06-11 00:20 +0200
  Re: [PATCH] ARM: bcm2835: remove unused __packet Arnd Bergmann <arnd@arndb.de> - 2016-06-13 18:00 +0200

csiph-web