Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1419733
| From | "Luis R. Rodriguez" <mcgrof@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] coccicheck: add indexing enhancement options |
| Date | 2016-06-10 23:20 +0200 |
| Message-ID | <rIC0p-1ZM-7@gated-at.bofh.it> (permalink) |
| References | <rIBxn-1rC-7@gated-at.bofh.it> <rIBxn-1rC-17@gated-at.bofh.it> <rIBQJ-1R3-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 10, 2016 at 11:02:38PM +0200, Julia Lawall wrote: > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > Enable indexing optimizations heuristics. Coccinelle has > > support to make use of its own enhanced "grep" mechanisms > > instead of using regular grep for searching code 'coccigrep', > > in practice though this seems to not perform better than > > regular grep however its expected to help with some use cases > > so we use that if you have no other indexing options in place > > available. > > > > Since git has its own index, support for using 'git grep' has been > > added to Coccinelle, that should on average perform better than > > using the internal cocci grep, and regular grep. Lastly, Coccinelle > > has had support for glimpseindex for a long while, however the > > tool was previously closed source, its now open sourced, and > > provides the best performance, so support that if we can detect > > you have a glimpse index. > > > > These tests have been run on an 8 core system: > > > > Before: > > > > $ export COCCI=scripts/coccinelle/free/kfree.cocci > > $ time make coccicheck MODE=report > > > > Before this patch with no indexing or anything: > > > > real 16m22.435s > > user 128m30.060s > > sys 0m2.712s > > > > Using coccigrep (after this patch if you have no .git): > > > > real 16m27.650s > > user 128m47.904s > > sys 0m2.176s > > > > If you have .git and therefore use gitgrep: > > > > real 16m21.220s > > user 129m30.940s > > sys 0m2.060s > > > > And if you have a .glimpse_index: > > > > real 16m14.794s > > user 128m42.356s > > sys 0m1.880s > > I don't see any convincing differences in these times. > > I believe that Coccinelle's internal grep is always used, even with no > option. Ah that would explain it. This uses coccinelle 1.0.5, is the default there to use --use-coccigrep if no other index is specified ? > I'm puzzled why glimpse gives no benefit. Well, slightly better. Luis
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] scripts/coccicheck: add paramap and indexing options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-10 22:50 +0200
[PATCH 2/4] coccicheck: enable paramap support "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-10 22:50 +0200
Re: [Cocci] [PATCH 2/4] coccicheck: enable paramap support SF Markus Elfring <elfring@users.sourceforge.net> - 2016-06-11 08:00 +0200
Re: [Cocci] [PATCH 2/4] coccicheck: enable paramap support Julia Lawall <julia.lawall@lip6.fr> - 2016-06-11 08:00 +0200
[PATCH 3/4] scripts: add glimpse.sh for indexing the kernel "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-10 22:50 +0200
Re: [Cocci] [PATCH 3/4] scripts: add glimpse.sh for indexing the kernel SF Markus Elfring <elfring@users.sourceforge.net> - 2016-06-11 19:20 +0200
[PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-10 22:50 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-10 23:10 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-10 23:20 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-10 23:30 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Wolfram Sang <wsa@the-dreams.de> - 2016-06-10 23:50 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-10 23:50 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Wolfram Sang <wsa@the-dreams.de> - 2016-06-11 00:00 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-11 00:10 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-11 00:30 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Wolfram Sang <wsa@the-dreams.de> - 2016-06-11 07:50 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-11 08:00 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Wolfram Sang <wsa@the-dreams.de> - 2016-06-11 08:10 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-13 20:40 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Wolfram Sang <wsa@the-dreams.de> - 2016-06-13 21:00 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-13 21:50 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-13 23:30 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-14 07:10 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-11 07:20 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Wolfram Sang <wsa@the-dreams.de> - 2016-06-11 08:00 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-11 08:10 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-11 07:30 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-13 20:50 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-11 07:20 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-13 21:40 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-13 22:00 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-13 23:30 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-14 07:30 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-14 21:30 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-14 22:50 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-14 23:20 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-14 23:20 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 00:10 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-15 09:50 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 17:40 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options Julia Lawall <julia.lawall@lip6.fr> - 2016-06-15 17:50 +0200
Re: [PATCH 4/4] coccicheck: add indexing enhancement options "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-06-15 20:00 +0200
Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options SF Markus Elfring <elfring@users.sourceforge.net> - 2016-06-11 08:00 +0200
Re: [Cocci] [PATCH 0/4] scripts/coccicheck: add paramap and indexing options SF Markus Elfring <elfring@users.sourceforge.net> - 2016-06-11 07:30 +0200
csiph-web