Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1418186

Re: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking
Date 2016-06-09 11:10 +0200
Message-ID <rI48p-4md-7@gated-at.bofh.it> (permalink)
References <rHT3k-5qw-5@gated-at.bofh.it> <rHTd0-5vo-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 8 Jun 2016, David Kershner wrote:
> +	/*
> +	 * If we're not paused, really enable interrupts.
> +	 * Regardless of whether we are paused, set a flag indicating
> +	 * interrupts should be enabled so when we resume, interrupts
> +	 * will really be enabled.
> +	 */
> +	down_write(&devdata->lock_visor_dev);

I think I asked this before, but I might have missed the answer.

Why is this a rw_sempahore? It's never taken with down_read and looking at the
usage sites it's simply a mutex, right?

Thanks,

	tglx

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary locking David Kershner <david.kershner@unisys.com> - 2016-06-08 23:30 +0200
  Re: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary  locking Thomas Gleixner <tglx@linutronix.de> - 2016-06-09 11:10 +0200
    RE: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary  locking "Sell, Timothy C" <Timothy.Sell@unisys.com> - 2016-06-09 14:10 +0200
      RE: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary  locking Thomas Gleixner <tglx@linutronix.de> - 2016-06-09 22:00 +0200
        RE: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary  locking "Sell, Timothy C" <Timothy.Sell@unisys.com> - 2016-06-09 22:40 +0200
        RE: [PATCH v4 09/29] staging: unisys: visorinput: remove unnecessary  locking "Sell, Timothy C" <Timothy.Sell@unisys.com> - 2016-06-11 05:40 +0200

csiph-web