Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint

From	Daniel Bristot de Oliveira <daolivei@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint
Date	2016-06-08 02:20 +0200
Message-ID	<rHznX-1aY-3@gated-at.bofh.it> (permalink)
References	<rDrS1-59z-13@gated-at.bofh.it> <rDrS2-59z-35@gated-at.bofh.it> <rEvgR-4GH-5@gated-at.bofh.it> <rH8QP-Oc-37@gated-at.bofh.it> <rH9Wy-1Fh-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/06/2016 06:03 PM, Peter Zijlstra wrote:
>>>> > >> +/*
>>>> > >> + * Tracepoint for priority changes of a task.
>>>> > >> + */
>>>> > >> +DEFINE_EVENT(sched_prio_template, sched_set_prio,
>>>> > >> +		TP_PROTO(struct task_struct *tsk, int newprio),
>>>> > >> +		TP_ARGS(tsk, newprio));
>>>> > >> +
> Nak on anything that cannot fundamentally deal with SCHED_DEADLINE.

My 2 cents: I liked the idea... But, I agree with peterz. This cannot
fundamentally deal with deadline scheduler.

In the deadline scheduler, the priority is set at every new sporadic
activation of the task (it is a fixed job priority scheduler - not a
fixed priority scheduler). The priority is the deadline of the new job.
The deadline is an u64, that does not fit in the int prio - so it cannot
be reused.

-- Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-06-06 22:00 +0200
  Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint Peter Zijlstra <peterz@infradead.org> - 2016-06-06 23:10 +0200
    Re: [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint Daniel Bristot de Oliveira <daolivei@redhat.com> - 2016-06-08 02:20 +0200

csiph-web