Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1416717

[PATCH 2/3] tpm, tpm_crb: remove wmb()'s

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] tpm, tpm_crb: remove wmb()'s
Date 2016-06-08 01:10 +0200
Message-ID <rHyif-wP-53@gated-at.bofh.it> (permalink)
References <rHyie-wP-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


wmb()'s are not needed as iowrite32() is used.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/char/tpm/tpm_crb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index b4d46ae..ca2cad9 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -175,9 +175,6 @@ static void crb_cancel(struct tpm_chip *chip)
 
 	iowrite32(cpu_to_le32(CRB_CANCEL_INVOKE), &priv->cca->cancel);
 
-	/* Make sure that cmd is populated before issuing cancel. */
-	wmb();
-
 	if ((priv->flags & CRB_FL_ACPI_START) && crb_do_acpi_start(chip))
 		dev_err(&chip->dev, "ACPI Start failed\n");
 }
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] Runtime PM for TPM2 CRB chips Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-08 01:10 +0200
  [PATCH 2/3] tpm, tpm_crb: remove wmb()'s Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-08 01:10 +0200
  [PATCH 3/3] tpm, tpm_crb: runtime power management Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-08 01:10 +0200
  [PATCH 1/3] tpm_crb: fix crb_req_canceled behavior Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-06-08 01:10 +0200

csiph-web