Re: [PATCH v1 00/25] PCI: Request host bridge window resources

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 00/25] PCI: Request host bridge window resources
Date	2016-06-08 01:40 +0200
Message-ID	<rHyLg-GT-37@gated-at.bofh.it> (permalink)
References	<rHbOF-2YU-3@gated-at.bofh.it> <rHkRX-qE-5@gated-at.bofh.it> <rHp5f-3b5-7@gated-at.bofh.it> <rHpeW-3ek-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 07, 2016 at 03:25:46PM +0200, Arnd Bergmann wrote:
> On Tuesday, June 7, 2016 8:11:05 AM CEST Bjorn Helgaas wrote:
> > > 
> > > What do you think is the correct behavior here, should the driver only
> > > request the PIO range with parent=ioport_resource, or should it also
> > > request the MMIO window for the I/O ports with parent=iomem_resource?
> > > In the latter case, any idea how that can be generalized?
> > 
> > I think it should request both because I think iomem_resource should
> > contain everything in the memory map.  This would be required if we ever
> > did any significant reassignment of top-level devices, e.g., ACPI devices.
> 
> Ok. Should we try to pass the mmio resource for the I/O window to
> the devm_request_pci_bus_resources() function along with the other
> arguments then?

I think memory-mapped I/O port windows are different enough that maybe
we ought to handle them separately.  It seems like there are several
things related to setting up those windows (requesting the resource,
ioremapping it, allocating the CPU port number space, etc.), and maybe
if we keep this out, a pattern will emerge.

Maybe I should rename this to "devm_request_pci_host_windows()" or
something?

> As far as I can tell, it should not go into the resource list
> because it is not something the PCI core code should access the
> way it handles the other resources.

Right.

Bjorn

Thread

[PATCH v1 00/25] PCI: Request host bridge window resources Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:10 +0200
  [PATCH v1 01/25] PCI: Add devm_request_pci_bus_resources() Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:10 +0200
  [PATCH v1 12/25] PCI: xilinx-nwl: Use dev_printk() when possible Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:10 +0200
  [PATCH v1 14/25] PCI: altera: Simplify host bridge window iteration Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:10 +0200
  [PATCH v1 22/25] PCI: tegra: Remove top-level resource from  hierarchy Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:10 +0200
  [PATCH v1 02/25] PCI: designware: Free bridge resource list on  failure Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:20 +0200
  [PATCH v1 11/25] PCI: xilinx-nwl: Request host bridge window  resources Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:20 +0200
  [PATCH v1 06/25] PCI: xgene: Free bridge resource list on failure Bjorn Helgaas <bhelgaas@google.com> - 2016-06-07 01:20 +0200
  Re: [PATCH v1 00/25] PCI: Request host bridge window resources Arnd Bergmann <arnd@arndb.de> - 2016-06-07 10:50 +0200
    Re: [PATCH v1 00/25] PCI: Request host bridge window resources Bjorn Helgaas <helgaas@kernel.org> - 2016-06-07 15:20 +0200
      Re: [PATCH v1 00/25] PCI: Request host bridge window resources Arnd Bergmann <arnd@arndb.de> - 2016-06-07 15:30 +0200
        Re: [PATCH v1 00/25] PCI: Request host bridge window resources Bjorn Helgaas <helgaas@kernel.org> - 2016-06-08 01:40 +0200
  Re: [PATCH v1 00/25] PCI: Request host bridge window resources Duc Dang <dhdang@apm.com> - 2016-06-10 21:10 +0200

csiph-web