Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416680
| From | Joshua Kinard <kumba@gentoo.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ? |
| Date | 2016-06-08 00:30 +0200 |
| Message-ID | <rHxFv-8uO-1@gated-at.bofh.it> (permalink) |
| References | <rHqXo-4lt-55@gated-at.bofh.it> <rHrgK-4rU-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/07/2016 11:30, Alexandre Belloni wrote: > Hi, > > On 07/06/2016 at 16:18:31 +0100, David Binderman wrote : >> Hello there, >> [snip] >> Duplicate. Also in the same file: >> >> [drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a >> value that is never used. This looks like it can be removed. I believe it's a relic of before I added the handling of either BCD or Binary modes for the SGI Octane's RTC interface. >> [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a >> value that is never used. This needs to be wrapped in #ifdef CONFIG_RTC_DS1685_PROC_REGS, as the value of 'ctrlc' is displayed in /proc/drivers/rtc if that kconfig option is selected on supported systems. -- Joshua Kinard Gentoo/MIPS kumba@gentoo.org 6144R/F5C6C943 2015-04-27 177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943 "The past tempts us, the present confuses us, the future frightens us. And our lives slip away, moment by moment, lost in that vast, terrible in-between." --Emperor Turhan, Centauri Republic
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ? David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-07 17:20 +0200
Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ? Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-07 17:40 +0200
Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ? Joshua Kinard <kumba@gentoo.org> - 2016-06-08 00:30 +0200
csiph-web