Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416652

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY version 0x200

Show all headers | View raw

On Tue, Jun 07, 2016 at 05:10:51PM -0400, Lyude Paul wrote:
> Managed to find someone in the office with one of these laptops and it looks
> like the adaptive keyboard works perfectly with this patch, so I can give my t-
> b:
> 
> 	Tested-by: Lyude Paul <cpaul@redhat.com>
> 
> Cheers,
> 	Lyude
> 
> On Tue, 2016-06-07 at 13:02 -0400, Lyude Paul wrote:
> > Since nothing's really happened with this patch for a while I figured I'd take
> > over trying to get this upstream.
> > 
> > Regarding testing: This seems to work fine on the 60 series laptops, and works
> > fine on previous generations. The one thing I haven't been able to test is an
> > X1
> > carbon with an adaptive keyboard since I don't seem to have one readily
> > available here. I'm doing a search around the office to try to find someone
> > who
> > didn't throw theirs away yet so hopefully I should be able to get back to you
> > on
> > that soon.
> > 
> > To Dennis: I took the liberty of doing a review of your patch and some
> > testing.
> > There's a few things that need changing, I've outlined them below: (for the
> > future, it's recommended to send patches for the kernel inline in emails to
> > make
> > them easier to review).

If someone would please update the patch with any pending changes from review
and so it follows the rules in Documentation/SubmittingPatches, including the
complete list of recipients on Cc, we can move this forward.

Regards,

-- 
Darren Hart
Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] thinkpad_acpi: Add support for HKEY version 0x200 Lyude Paul <cpaul@redhat.com> - 2016-06-07 19:10 +0200
  Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY  version 0x200 Lyude Paul <cpaul@redhat.com> - 2016-06-07 23:20 +0200
    Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY  version 0x200 Darren Hart <dvhart@infradead.org> - 2016-06-07 23:50 +0200
    Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY  version 0x200 Marco Trevisan (Treviño) <mail@3v1n0.net> - 2016-06-08 00:10 +0200
      Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for HKEY  version 0x200 Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-06-08 02:00 +0200
        [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200 Lyude <cpaul@redhat.com> - 2016-06-08 17:00 +0200
          Re: [PATCH v2] thinkpad_acpi: Add support for HKEY version 0x200 Darren Hart <dvhart@infradead.org> - 2016-06-08 21:40 +0200
          Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY  version 0x200 Marco Trevisan (Treviño) <mail@3v1n0.net> - 2016-06-09 07:20 +0200
            Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY  version 0x200 Darren Hart <dvhart@infradead.org> - 2016-06-09 22:00 +0200
              Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY  version 0x200 Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-06-09 23:10 +0200
                Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for HKEY  version 0x200 Darren Hart <dvhart@infradead.org> - 2016-06-10 00:00 +0200

csiph-web