Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416493

Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

Show all headers | View raw

On Tue, Jun 07, 2016 at 06:52:22PM +0200, Borislav Petkov wrote:
> +void mce_log(struct mce *m)
>  {
>  	unsigned next, entry;
>  
> +	if (!in_atomic() && memory_error(m) && mce_usable_address(m))
> +		if (!ce_add_elem(m->addr >> PAGE_SHIFT))
> +			return;
> +
>  	/* Emit the trace record: */
> -	trace_mce_record(mce);
> +	trace_mce_record(m);
>  
> -	if (!mce_gen_pool_add(mce))
> +	if (!mce_gen_pool_add(m))
>  		irq_work_queue(&mce_irq_work);

Is there a reason that we need to call the ce_add_elem() inline
here instead of having it just register on the mce_notifier chain?
This series just cleaned out all the /dev/mcelog special code from
here, and you are adding something back before the ink is dry on
that change.

I'm also strongly divided about whether this corrected error
handler should be allowed to preempt anything else even seeing
the error.

Argument for:
Lonely corrected errors are "No Big Deal"(TM). Just counting them
and moving on is a good thing.

Arguments against:
1) We may miss out on a one-time opportunity to get extra information
(from acpi_extlog.c).
2) I think this subverts our CMCI storm detection and mitigation code?


We could make the chain more caller friendly by adding a filter
argument so users could say "just tell me about memory errors"
(currently each of the EDAC drivers has inline code to do the same
as "memory_error(m) && mce_usable_address(m)")

-Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[R-F-C PATCH 0/4] RFC: x86/mce: Deprecate mcelog and other funsies Borislav Petkov <bp@alien8.de> - 2016-06-07 19:00 +0200
  [RFC PATCH 4/4] x86/mce-inject: Use debugfs_remove_recursive() Borislav Petkov <bp@alien8.de> - 2016-06-07 19:00 +0200
  [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector Borislav Petkov <bp@alien8.de> - 2016-06-07 19:00 +0200
    Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector "Luck, Tony" <tony.luck@intel.com> - 2016-06-07 20:20 +0200
      Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector Borislav Petkov <bp@alien8.de> - 2016-06-07 23:10 +0200

csiph-web