Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning
Date	2016-06-07 19:20 +0200
Message-ID	<rHsPv-5vs-5@gated-at.bofh.it> (permalink)
References	<rHsmt-56I-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-06-07 at 12:43 -0400, George Spelvin wrote:
> Andy Shevchenko wrote:
> > To be sure it faster we need the measurements. Sometimes it's not
> > obvious.
[]
> Speaking pedantically, you're right.  But as a practical matter, it's
> very unlikely, and what makes it truly insignificant is that it's not
> really a problem even if I'm wrong and the code *is* slower.
> 
> As you said, size is more important than speed, and I did, at your
> request, benchmark that.  I'm just trying to make the sort of changes
> that improve *both*.
> 
> If you have a realistic concern that the patches degrade speed, I can
> put in a few hours of work to put the different versions into a test
> harness and measure it accurately.
> 
> But if this is just a pro forma observation that estimates aren't
> perfectly reliable, it's not worth the effort.

Readability and correctness are probably more important than
runtime performance here.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] Clean up and shrink uuid input & output "George Spelvin" <linux@sciencehorizons.net> - 2016-06-04 07:20 +0200
  [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string() "George Spelvin" <linux@sciencehorizons.net> - 2016-06-04 07:20 +0200
    Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-05 16:30 +0200
      Re: [PATCH v2 1/2] lib/vsprintf.c: Simplify uuid_string() "George Spelvin" <linux@sciencehorizons.net> - 2016-06-05 22:00 +0200
  [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays "George Spelvin" <linux@sciencehorizons.net> - 2016-06-04 07:20 +0200
    Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays kbuild test robot <lkp@intel.com> - 2016-06-04 08:00 +0200
    Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays Joe Perches <joe@perches.com> - 2016-06-04 18:30 +0200
      Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays "George Spelvin" <linux@sciencehorizons.net> - 2016-06-05 00:00 +0200
      Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-05 16:20 +0200
        Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays Joe Perches <joe@perches.com> - 2016-06-05 17:40 +0200
          Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-05 18:20 +0200
  [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning "George Spelvin" <linux@sciencehorizons.net> - 2016-06-04 15:20 +0200
    Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value  warning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-05 16:20 +0200
      Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning "George Spelvin" <linux@sciencehorizons.net> - 2016-06-05 21:30 +0200
        Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value  warning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-06-06 10:30 +0200
          Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value warning "George Spelvin" <linux@sciencehorizons.net> - 2016-06-07 18:50 +0200
            Re: [PATCH v2 3/2] lib/uuid.c: Silence an unchecked return value  warning Joe Perches <joe@perches.com> - 2016-06-07 19:20 +0200

csiph-web