Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416431

Re: [PATCH 2/3] ntb_transport: Check the number of spads the hardware supports

Show all headers | View raw

Hi Jon,

Thanks for the feedback. I'll send an updated patch in a moment.

On 04/06/16 09:40 AM, Jon Mason wrote:
> Nit, please add spaces around '*' (per checkpatch)

I'll change this, but I did run it through checkpatch and it did not
warn about this.

> Please explicitly point out that this is being modified in the commit
> message.  I don't see them being used, so probably not a big deal
> (unless Dave Jiang has something queued that will use it).

Done. I feel like he can always add them back in when he adds the
functionality. This way, when he does, MAX_SPAD will be updated and the
check will still be correct.

> Move this check above the dev_to_node assignment above.

Done.


Logan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] ntb_transport: Check the number of spads the  hardware supports Jon Mason <jdmason@kudzu.us> - 2016-06-04 17:50 +0200
  Re: [PATCH 2/3] ntb_transport: Check the number of spads the hardware  supports Logan Gunthorpe <logang@deltatee.com> - 2016-06-07 19:20 +0200
    Re: [PATCH v2 2/3] ntb_transport: Check the number of spads the  hardware supports "Jiang, Dave" <dave.jiang@intel.com> - 2016-06-07 19:30 +0200
      Re: [PATCH v2 2/3] ntb_transport: Check the number of spads the  hardware supports Jon Mason <jdmason@kudzu.us> - 2016-06-09 17:00 +0200

csiph-web