Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1416313

linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style) Redundant condition

From David Binderman <linuxdev.baldrick@gmail.com>
Newsgroups linux.kernel
Subject linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style) Redundant condition
Date 2016-06-07 17:30 +0200
Message-ID <rHr74-4oQ-9@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Hello there,

linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style)
Redundant condition: If 'msrc > 1', the comparison 'msrc' is always
true.

Source code is

            if (msrc && msrc > 1) {

Maybe better code

            if (msrc > 1) {


Regards

David Binderman

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

linux-4.7-rc2/drivers/video/fbdev/intelfb/intelfbdrv.c:1041]: (style)  Redundant condition David Binderman <linuxdev.baldrick@gmail.com> - 2016-06-07 17:30 +0200

csiph-web