Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1416201

Re: [PATCH] mm, oom_reaper: make sure that mmput_async is called only when memory was reaped

From kbuild test robot <lkp@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mm, oom_reaper: make sure that mmput_async is called only when memory was reaped
Date 2016-06-07 15:50 +0200
Message-ID <rHpyh-3ll-7@gated-at.bofh.it> (permalink)
References <rHp5f-3b5-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi,

[auto build test ERROR on next-20160607]
[cannot apply to v4.7-rc2 v4.7-rc1 v4.6-rc7 v4.7-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-oom_reaper-make-sure-that-mmput_async-is-called-only-when-memory-was-reaped/20160607-211715
config: i386-defconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   mm/oom_kill.c: In function '__oom_reap_task':
>> mm/oom_kill.c:490:22: error: passing argument 1 of 'mmget_not_zero' from incompatible pointer type [-Werror=incompatible-pointer-types]
     if (!mmget_not_zero(&mm->mm_users)) {
                         ^
   In file included from include/linux/oom.h:5:0,
                    from mm/oom_kill.c:20:
   include/linux/sched.h:2746:20: note: expected 'struct mm_struct *' but argument is of type 'atomic_t * {aka struct <anonymous> *}'
    static inline bool mmget_not_zero(struct mm_struct *mm)
                       ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/mmget_not_zero +490 mm/oom_kill.c

   484	
   485		/*
   486		 * increase mm_users only after we know we will reap something so
   487		 * that the mmput_async is called only when we have reaped something
   488		 * and delayed __mmput doesn't matter that much
   489		 */
 > 490		if (!mmget_not_zero(&mm->mm_users)) {
   491			up_read(&mm->mmap_sem);
   492			goto mm_drop;
   493		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm, oom_reaper: make sure that mmput_async is called only when memory was reaped Michal Hocko <mhocko@kernel.org> - 2016-06-07 15:20 +0200
  Re: [PATCH] mm, oom_reaper: make sure that mmput_async is called  only when memory was reaped kbuild test robot <lkp@intel.com> - 2016-06-07 15:40 +0200
    Re: [PATCH] mm, oom_reaper: make sure that mmput_async is called  only when memory was reaped Michal Hocko <mhocko@kernel.org> - 2016-06-07 15:50 +0200
  Re: [PATCH] mm, oom_reaper: make sure that mmput_async is called  only when memory was reaped kbuild test robot <lkp@intel.com> - 2016-06-07 15:50 +0200
  [PATCH] mm, oom_reaper: make sure that mmput_async is called only when memory was reaped Michal Hocko <mhocko@kernel.org> - 2016-06-07 15:50 +0200

csiph-web