Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY
Date	2016-06-07 15:50 +0200
Message-ID	<rHpyh-3ll-21@gated-at.bofh.it> (permalink)
References	<rFZFU-5aq-5@gated-at.bofh.it> <rFZFU-5aq-3@gated-at.bofh.it> <rH3Hs-65l-17@gated-at.bofh.it> <rHddL-3KJ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 6, 2016 at 7:33 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> Hi Rob
>
>
> On 06/06/2016 10:27 PM, Rob Herring wrote:
>>
>> On Fri, Jun 03, 2016 at 11:15:08PM +0800, Chris Zhong wrote:
>>>
>>> This patch adds a binding that describes the Rockchip USB Type-C PHY
>>> for rk3399
>>>
>>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>>
>>> ---
>>>
>>> Changes in v1:
>>> - add extcon node description
>>> - move the registers in phy driver
>>> - remove the suffix of reset
>>>
>>>   .../devicetree/bindings/phy/phy-rockchip-typec.txt | 46
>>> ++++++++++++++++++++++
>>>   1 file changed, 46 insertions(+)
>>>   create mode 100644
>>> Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
>>> b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
>>> new file mode 100644
>>> index 0000000..964e0f7
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt
>>> @@ -0,0 +1,46 @@
>>> +* ROCKCHIP type-c PHY
>>> +---------------------
>>> +
>>> +Required properties:
>>> + - compatible: should be "rockchip,rk3399-typec-phy0" or
>>> +                        "rockchip,rk3399-typec-phy1"
>>
>> What's the difference between 0 and 1? If it is to handle the register
>> offsets you have in the previous version and the phy blocks are
>> identical, then the compatible strings should be the same.
>
> yes, the registers are different between 0 and 1, and there is a grf
> register(0x6268) for switch the phy 0 and phy 1

But GRF is in a separate block and not part of the phy, right?

Rob

Thread

[v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip USB Type-C PHY Chris Zhong <zyw@rock-chips.com> - 2016-06-03 18:00 +0200
  Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip  USB Type-C PHY Rob Herring <robh@kernel.org> - 2016-06-06 16:30 +0200
    Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip  USB Type-C PHY Chris Zhong <zyw@rock-chips.com> - 2016-06-07 02:40 +0200
      Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip  USB Type-C PHY Rob Herring <robh@kernel.org> - 2016-06-07 15:50 +0200
        Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip  USB Type-C PHY Chris Zhong <zyw@rock-chips.com> - 2016-06-08 03:40 +0200
          Re: [v1 PATCH 1/4] Documentation: bindings: add dt doc for Rockchip  USB Type-C PHY Rob Herring <robh@kernel.org> - 2016-06-08 21:20 +0200

csiph-web