Re: [PATCH 1/3] firmware: arm_scpi: add support for device power state management

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Jon Medhurst (Tixy)" <tixy@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] firmware: arm_scpi: add support for device power state management
Date	Tue, 07 Jun 2016 15:00:01 +0200
Message-ID	<rHoLT-2Pn-7@gated-at.bofh.it> (permalink)
References	<rH56x-6VJ-11@gated-at.bofh.it> <rH56y-6VJ-31@gated-at.bofh.it>
X-Original-To	Sudeep Holla <sudeep.holla@arm.com>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.12.9-1+b1
MIME-Version	1.0
Content-Transfer-Encoding	7bit
X-Originating-Smarthost01d-IP	[82.69.122.217]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	66
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, linux-arm-kernel@lists.infradead.org
X-Original-Date	Tue, 07 Jun 2016 13:58:25 +0100
X-Original-Message-ID	<1465304305.2833.13.camel@linaro.org>
X-Original-References	<1465228439-13457-1-git-send-email-sudeep.holla@arm.com> <1465228439-13457-2-git-send-email-sudeep.holla@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1416143

Show key headers only | View raw

On Mon, 2016-06-06 at 16:53 +0100, Sudeep Holla wrote:
> SCPI protocol supports device power state management. This deals with
> power states of various peripheral devices in the system other than the
> core compute subsystem.
> 
> This patch adds support for the power state management of those
> peripheral devices.
> 
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/firmware/arm_scpi.c   | 29 +++++++++++++++++++++++++++++
>  include/linux/scpi_protocol.h |  2 ++
>  2 files changed, 31 insertions(+)
> 
> diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
> index 51c6db0774cc..ca6afd2217a8 100644
> --- a/drivers/firmware/arm_scpi.c
> +++ b/drivers/firmware/arm_scpi.c
> @@ -231,6 +231,11 @@ struct sensor_value {
>  	__le32 hi_val;
>  } __packed;
> 
> +struct dev_pstate_set {
> +	u16 dev_id;
> +	u8 pstate;
> +} __packed;
> +
>  static struct scpi_drvinfo *scpi_info;
> 
>  static int scpi_linux_errmap[SCPI_ERR_MAX] = {
> @@ -537,6 +542,28 @@ static int scpi_sensor_get_value(u16 sensor, u64 *val)
>  	return ret;
>  }
> 
> +static int scpi_device_get_power_state(u16 dev_id)
> +{
> +	int ret;
> +	u8 pstate;
> +
> +	ret = scpi_send_message(SCPI_CMD_GET_DEVICE_PWR_STATE, &dev_id,
> +				sizeof(dev_id), &pstate, sizeof(pstate));

Don't you need to run translate dev_id to little-endian before sending
it? You remembered to do that next function...

> +	return ret ? ret : pstate;
> +}
> +
> +static int scpi_device_set_power_state(u16 dev_id, u8 pstate)
> +{
> +	int stat;
> +	struct dev_pstate_set dev_set = {
> +		.dev_id = cpu_to_le16(dev_id),
> +		.pstate = pstate,
> +	};
> +
> +	return scpi_send_message(SCPI_CMD_SET_DEVICE_PWR_STATE, &dev_set,
> +				 sizeof(dev_set), &stat, sizeof(stat));
> +}
> +

[...]

-- 
Tixy

Thread

[PATCH 0/3] firmware: scpi: add device power domain support Sudeep Holla <sudeep.holla@arm.com> - 2016-06-06 18:00 +0200
  [PATCH 1/3] firmware: arm_scpi: add support for device power state management Sudeep Holla <sudeep.holla@arm.com> - 2016-06-06 18:00 +0200
    Re: [PATCH 1/3] firmware: arm_scpi: add support for device power  state management "Jon Medhurst (Tixy)" <tixy@linaro.org> - 2016-06-07 15:00 +0200
      Re: [PATCH 1/3] firmware: arm_scpi: add support for device power  state management Sudeep Holla <sudeep.holla@arm.com> - 2016-06-07 15:10 +0200

csiph-web