Re: [PATCH 2/2] IB/sysfs: fix memory leak

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] IB/sysfs: fix memory leak
Date	2016-06-07 14:00 +0200
Message-ID	<rHnPR-2e7-51@gated-at.bofh.it> (permalink)
References	<rGMGB-2Yp-3@gated-at.bofh.it> <rGMGB-2Yp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 6/5/2016 4:13 PM, Sudip Mukherjee wrote:
> If the allocation of hsag fails we were just returning but stats was
> not released.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/infiniband/core/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index fcf6f9c..8d8732c 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -906,7 +906,7 @@ static void setup_hw_stats(struct ib_device *device, struct ib_port *port,
>  		       sizeof(void *) * (stats->num_counters + 1),
>  		       GFP_KERNEL);
>  	if (!hsag)
> -		return;
> +		goto err;
>  
>  	ret = device->get_hw_stats(device, stats, port_num,
>  				   stats->num_counters);
> 

This issue was previously fixed by another patch and is no longer
applicable.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] IB/sysfs: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-06-05 22:20 +0200
  Re: [PATCH 2/2] IB/sysfs: fix memory leak Leon Romanovsky <leon@kernel.org> - 2016-06-06 08:40 +0200
    Re: [PATCH 2/2] IB/sysfs: fix memory leak Leon Romanovsky <leon@kernel.org> - 2016-06-06 14:20 +0200
  Re: [PATCH 2/2] IB/sysfs: fix memory leak Doug Ledford <dledford@redhat.com> - 2016-06-07 14:00 +0200

csiph-web