Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1415830

Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields

From Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields
Date 2016-06-07 10:20 +0200
Message-ID <rHkoW-gO-13@gated-at.bofh.it> (permalink)
References <rHafT-1OH-9@gated-at.bofh.it> <rHafV-1OH-71@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 06, 2016 at 11:20:43PM +0200, Christoph Hellwig wrote:
> These have been added in NVMe 1.2 and we'll need at least oaes for the
> NVMe target driver.
> 
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Jay Freyensee <james.p.freyensee@intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  include/linux/nvme.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 7d51b29..ff5ebc3 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -107,7 +107,10 @@ struct nvme_id_ctrl {
>  	__u8			mdts;
>  	__le16			cntlid;
>  	__le32			ver;
> -	__u8			rsvd84[172];
> +	__le32			rtd3r;
> +	__le32			rtd3e;
> +	__le32			oaes;

Just out of curiosity, why not CTRATT as well?

> +	__u8			rsvd96[160];
>  	__le16			oacs;
>  	__u8			acl;
>  	__u8			aerl;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

general preparation for NVMe over Fabrics support Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 03/10] nvme.h: add NVM command set SQE/CQE size defines Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 02/10] nvme.h: Add get_log_page command strucure Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 09/10] nvme: update nvme_cancel_io() a bit Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 04/10] nvme.h: add AER constants Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 08/10] nvme: move the workaround for I/O queue-less controllers from PCIe to core Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
    Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields Johannes Thumshirn <jthumshirn@suse.de> - 2016-06-07 10:20 +0200
      Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields Johannes Thumshirn <jthumshirn@suse.de> - 2016-06-07 10:40 +0200
      Re: [PATCH 01/10] nvme.h: add RTD3R, RTD3E and OAES fields Christoph Hellwig <hch@lst.de> - 2016-06-07 12:50 +0200
  [PATCH 06/10] nvme: allow for size limitations from transport drivers Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  [PATCH 07/10] nvme: factor out a add nvme_is_write helper Christoph Hellwig <hch@lst.de> - 2016-06-06 23:30 +0200
  Re: general preparation for NVMe over Fabrics support Keith Busch <keith.busch@intel.com> - 2016-06-09 18:40 +0200
    Re: general preparation for NVMe over Fabrics support Christoph Hellwig <hch@lst.de> - 2016-06-09 19:20 +0200

csiph-web