Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked.
Date	2016-06-07 09:20 +0200
Message-ID	<rHjsS-82q-19@gated-at.bofh.it> (permalink)
References	<rG9vz-2XA-3@gated-at.bofh.it> <rGUkS-8lg-7@gated-at.bofh.it> <rH6Fj-7Xq-3@gated-at.bofh.it> <rHhAJ-6QQ-11@gated-at.bofh.it> <rHiwO-7rh-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote:
> >> >> -	if (ret == DMA_COMPLETE || !txstate)
> >> >> +	if (ret == DMA_COMPLETE)
> >> >
> >> > Why do you change this? txstate can be NULL, so no point calculating reside
> >> > for those cases
> >> 
> >> The point was to go into the "Calculate where we're at in our current
> >> DMA (if the current DMA is the one we're asking about status for)" path,
> >> so that we could note when the DMA is complete even when there's no
> >> txstate passed in.
> >
> > Can you explain what you mean by current DMA!
> >
> > The claulation is always done for 'descriptor' represnted by the cookie. So
> > it doesnt not matter...!
> 
> By current I mean the current descriptor that has been submitted to the
> hardware, in bcm2835_chan->desc.

As I said, you calculate for the descriptor respresnted by cookie and
not the one getting processed!

-- 
~Vinod

Thread

[PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked. Eric Anholt <eric@anholt.net> - 2016-06-04 04:30 +0200
  Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA  with interrupts masked. Vinod Koul <vinod.koul@intel.com> - 2016-06-06 06:30 +0200
    Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked. Eric Anholt <eric@anholt.net> - 2016-06-06 19:40 +0200
      Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA  with interrupts masked. Vinod Koul <vinod.koul@intel.com> - 2016-06-07 07:20 +0200
        Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked. Eric Anholt <eric@anholt.net> - 2016-06-07 08:20 +0200
          Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA  with interrupts masked. Vinod Koul <vinod.koul@intel.com> - 2016-06-07 09:20 +0200
            Re: [PATCH] dmaengine: bcm2835: Fix polling for completion of DMA with interrupts masked. Eric Anholt <eric@anholt.net> - 2016-06-07 23:00 +0200

csiph-web