RE: [PATCH v2 3/4] dmaengine: vdma: Add 64 bit addressing support for the axi dma

From	Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 3/4] dmaengine: vdma: Add 64 bit addressing support for the axi dma
Date	2016-06-07 08:20 +0200
Message-ID	<rHiwO-7rh-11@gated-at.bofh.it> (permalink)
References	<rA4oV-7vr-3@gated-at.bofh.it> <rA4oW-7vr-19@gated-at.bofh.it> <rHiwO-7rh-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Vinod,

> On Wed, May 18, 2016 at 01:17:32PM +0530, Kedareswara rao Appana wrote:
> > +		if (chan->cyclic) {
> > +			if (chan->ext_addr)
> > +				dma_writeq(chan,
> XILINX_DMA_REG_TAILDESC,
> > +					   chan->cyclic_seg_v->phys);
> > +			else
> > +				dma_ctrl_write(chan,
> XILINX_DMA_REG_TAILDESC,
> > +					       chan->cyclic_seg_v->phys);
> > +		} else {
> > +			if (chan->ext_addr)
> > +				dma_writeq(chan,
> XILINX_DMA_REG_TAILDESC,
> > +					   tail_segment->phys);
> > +			else
> > +				dma_ctrl_write(chan,
> XILINX_DMA_REG_TAILDESC,
> > +					       tail_segment->phys);
> 
> this looks ugly and repeated few times. Why not have xilinx_write() which does
> either dma_writeq or dma_ctrl_write based on channel..

Ok sure will fix in the next version...

> 
> > +			if (chan->ext_addr) {
> > +				hw->buf_addr = lower_32_bits(buf_addr +
> > +						sg_used + (period_len * i));
> > +				hw->buf_addr_msb = upper_32_bits(buf_addr +
> > +						sg_used + (period_len * i));
> > +			} else {
> > +				hw->buf_addr = buf_addr + sg_used +
> > +					       (period_len * i);
> > +			}
> 
> similar wrapper here would make code more readable

Ok Sure will fix in the next version...

Thanks,
Kedar.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH v2 3/4] dmaengine: vdma: Add 64 bit addressing support  for the axi dma Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> - 2016-06-07 08:20 +0200

csiph-web