[PATCH] ext4: mballoc.h typo fix: correct wrong comments about MB_DEFAULT_STREAM_THRESHOLD

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Lin Feng <linf@chinanetcenter.com>
Newsgroups	linux.kernel
Subject	[PATCH] ext4: mballoc.h typo fix: correct wrong comments about MB_DEFAULT_STREAM_THRESHOLD
Date	Tue, 07 Jun 2016 08:50:01 +0200
Message-ID	<rHiZP-7Do-3@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 1.9.3
X-Cm-Transid	AQAAf0Cphy8JblZXn_C9AA--.1449S2
X-Coremail-Antispam	1UD129KBjvJXoW7GF45WFyUurWDAryDtw4fXwb_yoW8JF1rpa 9rtw1fKrW3XF12k3Z3Ca4UGw18Gw4Sgw18JFZ0q34UZF47Jr4I9F4DKr18ZFyUZrWkXa1F qFWqy39rCr4rZa7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU2F1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l8cAvFVAK 0II2c7xJM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMc Ij6x8ErcxFaVAv8VW3tr1UJr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48J M4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6c x26FyDJr1UJwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr4UvcSsGvfC2KfnxnUUI43ZEXa7xUUbHrU UUUUU==
X-Cm-Senderinfo	holqwqxfkl0t5qhwuvhqwh2hhfrp/
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Lin Feng <linf@chinanetcenter.com>
X-Original-Date	Tue, 7 Jun 2016 14:47:35 +0800
X-Original-Message-ID	<1465282055-29042-1-git-send-email-linf@chinanetcenter.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1415752

Show key headers only | View raw

According to ext4_mb_group_or_file it's obviously that files larger
than s_mb_stream_request use stream allocator and smaller ones use
locality group allocator.

The original intention for stream allocator had been broken since
commit 4ba74d00a202 ("ext4: Fix bugs in mballoc's stream allocation mode")
and the comments for MB_DEFAULT_STREAM_THRESHOLD became stale.

Signed-off-by: Lin Feng <linf@chinanetcenter.com>
---
 fs/ext4/mballoc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index 3ef1df6..2e64c0e 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -59,10 +59,10 @@ extern ushort ext4_mballoc_debug;
 #define MB_DEFAULT_STATS		0
 
 /*
- * files smaller than MB_DEFAULT_STREAM_THRESHOLD are served
+ * files larger than MB_DEFAULT_STREAM_THRESHOLD are served
  * by the stream allocator, which purpose is to pack requests
  * as close each to other as possible to produce smooth I/O traffic
- * We use locality group prealloc space for stream request.
+ * We use locality group prealloc space for non stream request.
  * We can tune the same via /proc/fs/ext4/<parition>/stream_req
  */
 #define MB_DEFAULT_STREAM_THRESHOLD	16	/* 64K */
-- 
1.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] ext4: mballoc.h typo fix: correct wrong comments about MB_DEFAULT_STREAM_THRESHOLD Lin Feng <linf@chinanetcenter.com> - 2016-06-07 08:50 +0200

csiph-web