Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415757

Re: [PATCH 1/9] pinctrl: as3722: make it explicitly non-modular

Show all headers | View raw

On Tuesday 07 June 2016 08:13 AM, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_AS3722
>          bool "Pinctrl and GPIO driver for ams AS3722 PMIC"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_ALIAS and MODULE_DEVICE_TABLE are a no-op for
> non-modular code and hence both are removed.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>


I will say lets make the driver as tristate.

tristate "Pinctrl and GPIO driver for ams AS3722 PMIC"

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] pinctrl: make non-modular drivers really non modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200
  [PATCH 8/9] pinctrl: digicolor: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200
    Re: [PATCH 8/9] pinctrl: digicolor: make it explicitly non-modular Baruch Siach <baruch@tkos.co.il> - 2016-06-07 08:20 +0200
  [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200
    Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-06-07 05:00 +0200
    Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular Michal Simek <michal.simek@xilinx.com> - 2016-06-07 10:00 +0200
  [PATCH 3/9] pinctrl: at91: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200
  [PATCH 2/9] pinctrl: baytrail: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200
    Re: [PATCH 2/9] pinctrl: baytrail: make it explicitly non-modular Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-06-09 16:20 +0200
  [PATCH 1/9] pinctrl: as3722: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200
    Re: [PATCH 1/9] pinctrl: as3722: make it explicitly non-modular Laxman Dewangan <ldewangan@nvidia.com> - 2016-06-07 08:50 +0200
  [PATCH 4/9] pinctrl: lpc18xx: make it explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-06-07 04:50 +0200

csiph-web