Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415628

Re: [PATCH 06/10] mm: remove unnecessary use-once cache bias from LRU balancing

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote:
> When the splitlru patches divided page cache and swap-backed pages
> into separate LRU lists, the pressure balance between the lists was
> biased to account for the fact that streaming IO can cause memory
> pressure with a flood of pages that are used only once. New page
> cache
> additions would tip the balance toward the file LRU, and repeat
> access
> would neutralize that bias again. This ensured that page reclaim
> would
> always go for used-once cache first.
> 
> Since e9868505987a ("mm,vmscan: only evict file pages when we have
> plenty"), page reclaim generally skips over swap-backed memory
> entirely as long as there is used-once cache present, and will apply
> the LRU balancing when only repeatedly accessed cache pages are left
> -
> at which point the previous use-once bias will have been neutralized.
> 
> This makes the use-once cache balancing bias unnecessary. Remove it.
> 

The code in get_scan_count() still seems to use the statistics
of which you just removed the updating.

What am I overlooking?

-- 
All Rights Reversed.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 06/10] mm: remove unnecessary use-once cache bias from LRU balancing Johannes Weiner <hannes@cmpxchg.org> - 2016-06-06 22:00 +0200
  Re: [PATCH 06/10] mm: remove unnecessary use-once cache bias from  LRU balancing Rik van Riel <riel@redhat.com> - 2016-06-07 04:30 +0200
    Re: [PATCH 06/10] mm: remove unnecessary use-once cache bias from  LRU balancing Johannes Weiner <hannes@cmpxchg.org> - 2016-06-07 16:20 +0200
  Re: [PATCH 06/10] mm: remove unnecessary use-once cache bias from  LRU balancing Minchan Kim <minchan@kernel.org> - 2016-06-08 10:10 +0200
  Re: [PATCH 06/10] mm: remove unnecessary use-once cache bias from  LRU balancing Michal Hocko <mhocko@kernel.org> - 2016-06-08 14:40 +0200

csiph-web