Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1415502
| From | Oleg Nesterov <oleg@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag |
| Date | 2016-06-06 23:50 +0200 |
| Message-ID | <rHazf-1ZA-15@gated-at.bofh.it> (permalink) |
| References | <rFedX-qG-13@gated-at.bofh.it> <rFedX-qG-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/01, Dmitry Safonov wrote:
>
> static int fill_thread_core_info(struct elf_thread_core_info *t,
> const struct user_regset_view *view,
> - long signr, size_t *total)
> + long signr, size_t *total,
> + struct pt_regs *regs __maybe_unused)
> {
> unsigned int i;
>
> @@ -1652,11 +1653,11 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
> */
> fill_prstatus(&t->prstatus, t->task, signr);
> (void) view->regsets[0].get(t->task, &view->regsets[0],
> - 0, PR_REG_SIZE(t->prstatus.pr_reg),
> + 0, PR_REG_SIZE(t->prstatus.pr_reg, regs),
Hmm. I don't understand this... Note that this "regs" argument has nothing
to do with t->task if the process is multithreaded,
> @@ -1772,7 +1773,8 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
> * Now fill in each thread's information.
> */
> for (t = info->thread; t != NULL; t = t->next)
> - if (!fill_thread_core_info(t, view, siginfo->si_signo, &info->size))
> + if (!fill_thread_core_info(t, view, siginfo->si_signo,
> + &info->size, regs))
fill_note_info(..., args) is called with args = task_pt_regs(dumper_thread).
Oleg.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-06-01 15:20 +0200
Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag Cyrill Gorcunov <gorcunov@gmail.com> - 2016-06-03 12:00 +0200
Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-06-03 12:00 +0200
Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag Cyrill Gorcunov <gorcunov@gmail.com> - 2016-06-03 12:10 +0200
Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag Oleg Nesterov <oleg@redhat.com> - 2016-06-06 23:50 +0200
Re: [PATCH 4/6] x86/coredump: use core regs, rather that TIF_IA32 flag Oleg Nesterov <oleg@redhat.com> - 2016-06-07 01:50 +0200
csiph-web