Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1417901

[PATCH v4 08/29] staging: unisys: visorbus: removed unused periodic_test_workqueue

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From David Kershner <david.kershner@unisys.com>
Newsgroups linux.kernel
Subject [PATCH v4 08/29] staging: unisys: visorbus: removed unused periodic_test_workqueue
Date Wed, 08 Jun 2016 23:30:02 +0200
Message-ID <rHTd0-5vo-31@gated-at.bofh.it> (permalink)
References <rHT3k-5qw-5@gated-at.bofh.it>
X-Original-To <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>, <david.kershner@unisys.com>, <gregkh@linuxfoundation.org>, <erik.arfvidson@unisys.com>, <timothy.sell@unisys.com>, <hofrat@osadl.org>, <dzickus@redhat.com>, <jes.sorensen@redhat.com>, <alexander.curtin@unisys.com>, <janani.rvchndrn@gmail.com>, <sudipm.mukherjee@gmail.com>, <prarit@redhat.com>, <david.binder@unisys.com>, <nhorman@redhat.com>, <dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>, <driverdev-devel@linuxdriverproject.org>, <sparmaintainer@unisys.com>
X-Brightmail-Tracker H4sIAAAAAAAAA+NgFjrOIsWRWlGSWpSXmKPExsVywNY2U3dHV0S 4wcUZihYL25awWFzeNYfNgcnj8ya5AMYo1sy8pPyKBNaMDwu3shT84anovLKWpYFxPncXIxeH kMAuRok3rxawQTj7GSUe/mtggXAuMUpsuf+PFcJZyyhxpPktVGYLo8S3vyuZuhg5OdgEDCRm3 rnLDmKLCJxnkXh6K7eLkYODWUBN4sZ3S5CwsEC0xNybr8DKWQRUJJZPfM4MUsIr4CnxeDJYp4 SAnMTJY5NZQWxOAS+Jh7/WgpULAZW0vHvMDmGrSRw++4gNoj5Y4uDPh4wgNq+AoMTJmU9YQGx mAQmJgy9eME9gFJqFJDULSWoBI9MqRvXi1KKy1CJdM72kosz0jJLcxMwcXUMDC73c1OLixPTU nMSkYr3k/NxNjMAAZgCCHYyf+p0PMUpyMCmJ8pa5R4QL8SXlp1RmJBZnxBeV5qQWH2KU4eBQk uBN7gTKCRalpqdWpGXmAGMJJi3BwaMkwhsEkuYtLkjMLc5Mh0idYlSUEue1A0kIgCQySvPg2m Dxe4lRVkqYlxHoECGegtSi3MwSVPlXjOIcjErCvNkgU3gy80rgpr8CWswEtHj5kXCQxSWJCCm pBkaLFb1SU0XCmS8IC69buS5l9qXGfOkn65hCcjz0E5ed07lx7rGp9M3N6Q42q+t7pj5qzTdU SG5pEeD9+Eb9wrkLX4rkZurcsVskdGUl67dltpxv9XzsNnE+0ok1r5eRW3wgle/iYsc1vDnqn gVMD/Ypz59tWMt9123f68Y+XcuEzavYb+onWSmxFGckGmoxFxUnAgDibs3M2gIAAA==
X-Env-Sender David.Kershner@unisys.com
X-Msg-Ref server-14.tower-46.messagelabs.com!1465420467!29094340!20
X-Originating-IP [192.61.61.105]
X-Starscan-Version 8.46; banners=-,-,-
X-Viruschecked Checked
X-Mailer git-send-email 1.9.1
X-Originalarrivaltime 08 Jun 2016 21:14:27.0976 (UTC) FILETIME=[BDA5A880:01D1C1CA]
MIME-Version 1.0
Content-Type text/plain
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 45
Organization linux.* mail to news gateway
X-Original-Cc Tim Sell <Timothy.Sell@unisys.com>
X-Original-Date Wed, 8 Jun 2016 17:14:02 -0400
X-Original-Message-ID <1465420463-24982-9-git-send-email-david.kershner@unisys.com>
X-Original-References <1465420463-24982-1-git-send-email-david.kershner@unisys.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1417901

Show key headers only | View raw


From: Tim Sell <Timothy.Sell@unisys.com>

periodic_test_workqueue was an unused relic from the past, and was removed.

Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 756df41..ebdd5de 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -116,14 +116,6 @@ struct bus_type visorbus_type = {
 	.bus_groups = visorbus_bus_groups,
 };
 
-static struct delayed_work periodic_work;
-
-/* YES, we need 2 workqueues.
- * The reason is, workitems on the test queue may need to cancel
- * workitems on the other queue.  You will be in for trouble if you try to
- * do this with workitems queued on the same workqueue.
- */
-static struct workqueue_struct *periodic_test_workqueue;
 static struct workqueue_struct *periodic_dev_workqueue;
 static long long bus_count;	/** number of bus instances */
 					/** ever-increasing */
@@ -1309,13 +1301,6 @@ visorbus_exit(void)
 	destroy_workqueue(periodic_dev_workqueue);
 	periodic_dev_workqueue = NULL;
 
-	if (periodic_test_workqueue) {
-		cancel_delayed_work(&periodic_work);
-		flush_workqueue(periodic_test_workqueue);
-		destroy_workqueue(periodic_test_workqueue);
-		periodic_test_workqueue = NULL;
-	}
-
 	list_for_each_safe(listentry, listtmp, &list_all_bus_instances) {
 		struct visor_device *dev = list_entry(listentry,
 						      struct visor_device,
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH v4 08/29] staging: unisys: visorbus: removed unused periodic_test_workqueue David Kershner <david.kershner@unisys.com> - 2016-06-08 23:30 +0200

csiph-web