Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417850

Re: [PATCH 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY

Show all headers | View raw

gOn Wed, Jun 08, 2016 at 03:25:08PM +0800, Shawn Lin wrote:
> This patch adds a binding that describes the Rockchip PCIe PHY
> found on Rockchip SoCs PCIe interface.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  .../devicetree/bindings/phy/rockchip-pcie-phy.txt  | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
> 
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
> new file mode 100644
> index 0000000..ba8c406
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt
> @@ -0,0 +1,22 @@
> +Rockchip PCIE PHY
> +-----------------------
> +
> +Required properties:
> + - compatible: rockchip,rk3399-pcie-phy
> + - #phy-cells: must be 0
> +
> +Example:
> +
> +grf: syscon@ff770000 {
> +	compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd";
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +
> +	...
> +
> +	pcie_phy: phy@e220 {

unit-address needs a reg property or drop the unit address. I'd do the 
former if there's a register range you can describe here.


> +		compatible = "rockchip,rk3399-pcie-phy";
> +		#phy-cells = <0>;
> +	};
> +};
> +
> -- 
> 2.3.7
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY Shawn Lin <shawn.lin@rock-chips.com> - 2016-06-08 09:30 +0200
  Re: [PATCH 1/2] Documentation: bindings: add dt documentation for  Rockchip PCIe PHY Rob Herring <robh@kernel.org> - 2016-06-08 22:30 +0200
    Re: [PATCH 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY Heiko Stübner <heiko@sntech.de> - 2016-06-08 22:50 +0200
  Re: [PATCH 1/2] Documentation: bindings: add dt documentation for  Rockchip PCIe PHY Doug Anderson <dianders@chromium.org> - 2016-06-10 06:10 +0200

csiph-web