Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417649

[PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

Show all headers | View raw

With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM
it returns char *. Let's make that consistent. Also drop the
incorrect/inconsistent comment about char * above the nvmem_cell_read()
definition.

drivers/thermal/mtk_thermal.c is already working around this by casting
to (u32 *).

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/nvmem/core.c           | 4 ++--
 include/linux/nvmem-consumer.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 965911d9b36a..398ea7f54826 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -981,8 +981,8 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem,
  * @cell: nvmem cell to be read.
  * @len: pointer to length of cell which will be populated on successful read.
  *
- * Return: ERR_PTR() on error or a valid pointer to a char * buffer on success.
- * The buffer should be freed by the consumer with a kfree().
+ * Return: ERR_PTR() on error or a valid pointer to a buffer on success. The
+ * buffer should be freed by the consumer with a kfree().
  */
 void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
 {
diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
index 9bb77d3ed6e0..c2256d746543 100644
--- a/include/linux/nvmem-consumer.h
+++ b/include/linux/nvmem-consumer.h
@@ -74,7 +74,7 @@ static inline void nvmem_cell_put(struct nvmem_cell *cell)
 {
 }
 
-static inline char *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
+static inline void *nvmem_cell_read(struct nvmem_cell *cell, size_t *len)
 {
 	return ERR_PTR(-ENOSYS);
 }
-- 
2.8.0.rc3.226.g39d4020

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM Brian Norris <briannorris@chromium.org> - 2016-06-08 18:30 +0200
  Re: [PATCH] nvmem: fix nvmem_cell_read() return type for  !CONFIG_NVMEM Brian Norris <briannorris@chromium.org> - 2016-06-08 18:50 +0200
    Re: [PATCH] nvmem: fix nvmem_cell_read() return type for  !CONFIG_NVMEM Guenter Roeck <linux@roeck-us.net> - 2016-06-08 19:50 +0200
    Re: [PATCH] nvmem: fix nvmem_cell_read() return type for  !CONFIG_NVMEM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-06-08 21:00 +0200
      Re: [PATCH] nvmem: fix nvmem_cell_read() return type for  !CONFIG_NVMEM Brian Norris <briannorris@chromium.org> - 2016-06-08 22:10 +0200

csiph-web