Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model
Date	2016-06-08 18:10 +0200
Message-ID	<rHOdk-2nA-21@gated-at.bofh.it> (permalink)
References	<rH8QO-Oc-9@gated-at.bofh.it> <rH8QO-Oc-31@gated-at.bofh.it> <rHGSu-685-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 08, 2016 at 05:14:21PM +0900, Minchan Kim wrote:
> On Mon, Jun 06, 2016 at 03:48:33PM -0400, Johannes Weiner wrote:
> > @@ -249,15 +249,10 @@ void rotate_reclaimable_page(struct page *page)
> >  	}
> >  }
> >  
> > -static void update_page_reclaim_stat(struct lruvec *lruvec,
> > -				     int file, int rotated,
> > -				     unsigned int nr_pages)
> > +void lru_note_cost(struct lruvec *lruvec, bool file, unsigned int nr_pages)
> >  {
> > -	struct zone_reclaim_stat *reclaim_stat = &lruvec->reclaim_stat;
> > -
> > -	reclaim_stat->recent_scanned[file] += nr_pages;
> > -	if (rotated)
> > -		reclaim_stat->recent_rotated[file] += nr_pages;
> > +	lruvec->balance.numer[file] += nr_pages;
> > +	lruvec->balance.denom += nr_pages;
> 
> balance.numer[0] + balance.number[1] = balance.denom
> so we can remove denom at the moment?

You're right, it doesn't make sense to keep that around anymore. I'll
remove it.

Thanks!

Thread

[PATCH 07/10] mm: base LRU balancing on an explicit cost model Johannes Weiner <hannes@cmpxchg.org> - 2016-06-06 22:00 +0200
  Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model kbuild test robot <lkp@intel.com> - 2016-06-06 22:30 +0200
  Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Rik van Riel <riel@redhat.com> - 2016-06-07 04:40 +0200
    Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Johannes Weiner <hannes@cmpxchg.org> - 2016-06-07 16:20 +0200
  Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Minchan Kim <minchan@kernel.org> - 2016-06-08 10:20 +0200
    Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Johannes Weiner <hannes@cmpxchg.org> - 2016-06-08 18:10 +0200
  Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Michal Hocko <mhocko@kernel.org> - 2016-06-08 15:00 +0200
    Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Johannes Weiner <hannes@cmpxchg.org> - 2016-06-08 18:20 +0200
      Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Michal Hocko <mhocko@kernel.org> - 2016-06-09 14:20 +0200
        Re: [PATCH 07/10] mm: base LRU balancing on an explicit cost model Johannes Weiner <hannes@cmpxchg.org> - 2016-06-09 15:40 +0200

csiph-web