Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1417471
| From | Vince Weaver <vincent.weaver@maine.edu> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events |
| Date | 2016-06-08 16:10 +0200 |
| Message-ID | <rHMlc-1bu-11@gated-at.bofh.it> (permalink) |
| References | <rFL9U-4xF-29@gated-at.bofh.it> <rHJx0-7QB-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 8 Jun 2016, tip-bot for Dave Hansen wrote:
> Commit-ID: ef5f9f47d4ec4cf42bac48c7c4dafacc1b9f0630
> Gitweb: http://git.kernel.org/tip/ef5f9f47d4ec4cf42bac48c7c4dafacc1b9f0630
> Author: Dave Hansen <dave.hansen@linux.intel.com>
> AuthorDate: Thu, 2 Jun 2016 17:19:29 -0700
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed, 8 Jun 2016 12:05:58 +0200
>
> perf/x86/intel: Use Intel family macros for core perf events
>
> Use the new model number macros instead of spelling things out
> in the comments.
...
> #include "../perf_event.h"
> @@ -3319,11 +3320,11 @@ static int intel_snb_pebs_broken(int cpu)
> u32 rev = UINT_MAX; /* default to broken for unknown models */
>
> switch (cpu_data(cpu).x86_model) {
> - case 42: /* SNB */
> + case INTEL_FAM6_SANDYBRIDGE:
I personally find this a step backwards.
Currently it's bad enough when someone reports a problem with PAPI/perf
"my Xeon processor isn't detected properly"
eventually you can get them to send /proc/cpuinfo so you can try to find
out what processor they really have, and in that case you can get
the family/model numbers in plain decimal, and you can easily look up
if things are supported in the various files.
Now I then need to go look in the source, then find that it says
INTEL_FAM6_SANDYBRIDGE and then need to take the extra step to find
whatever header file defines these values.
Anway I doubt this will change anyone's mind but just wanted to register
my complaint.
Vince
and don't get me started about trying to somehow match a model number to a
code name using the AMD or intel documentation, without resorting to
wikipedia or random tech sites. I'm looking at you AMD fam15h model 60h.
Also "intel 6th generation i7"
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers Dave Hansen <dave@sr71.net> - 2016-06-03 02:20 +0200
[PATCH 03/20] x86, rapl: use Intel family macros for rapl Dave Hansen <dave@sr71.net> - 2016-06-03 02:20 +0200
[tip:perf/core] perf/x86/rapl: Use Intel family macros for RAPL tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 13:10 +0200
[PATCH 06/20] x86, msr: add missing Intel models Dave Hansen <dave@sr71.net> - 2016-06-03 02:20 +0200
[tip:perf/core] perf/x86/msr: Add missing Intel models tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 13:10 +0200
[PATCH 04/20] x86, intel_idle: use Intel family macros for intel_idle Dave Hansen <dave@sr71.net> - 2016-06-03 02:20 +0200
[tip:x86/cpu] x86/intel_idle: Use Intel family macros for intel_idle tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 12/20] x86, edac: use Intel family name macros for edac driver Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[PATCH 14/20] x86, acpi, lss: use Intel family name macros for lpss driver Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86/acpi/lss: Use Intel family name macros for the acpi_lpss driver tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 17/20] x86, mmc: use Intel family name macros for mmc driver Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86, mmc: Use Intel family name macros for mmc driver tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 07/20] x86, intel: use Intel model macros intead of open-coding Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86, powercap, rapl: Use Intel model macros intead of open-coding tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 20/20] x86, powercap, rapl: add Skylake Server model number Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86, powercap, rapl: Add Skylake Server model number tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 11/20] x86, uncore: use Intel family name macros for uncore Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:perf/core] perf/x86/uncore: Use Intel family name macros for uncore tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 13:10 +0200
[PATCH 02/20] x86, perf: use Intel family macros for core perf events Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 13:10 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Vince Weaver <vincent.weaver@maine.edu> - 2016-06-08 16:10 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Borislav Petkov <bp@alien8.de> - 2016-06-08 16:20 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Ingo Molnar <mingo@kernel.org> - 2016-06-08 18:30 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Borislav Petkov <bp@alien8.de> - 2016-06-08 18:40 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Stephane Eranian <eranian@google.com> - 2016-06-08 22:00 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Vince Weaver <vincent.weaver@maine.edu> - 2016-06-08 22:20 +0200
Re: [tip:perf/core] perf/x86/intel: Use Intel family macros for core perf events Borislav Petkov <bp@alien8.de> - 2016-06-08 22:50 +0200
[PATCH 08/20] x86, rapl: reorder cpu detection table Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86, powercap, rapl: Reorder CPU detection table tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 05/20] x86, msr: use Intel family macros for msr events code Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:perf/core] perf/x86/msr: Use Intel family macros for MSR events code tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 13:10 +0200
[PATCH 10/20] x86, cstate: use Intel Model name macros Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:perf/core] perf/x86/cstate: Use Intel Model name macros tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 13:10 +0200
[PATCH 09/20] x86, platform: use new Intel model number macros Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86/platform: Use new Intel model number macros tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 13/20] x86, cpufreq: use Intel family name macros for intel_pstate cpufreq driver Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86/cpufreq: Use Intel family name macros for the intel_pstate cpufreq driver tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 16/20] x86, pmc_core: use Intel family name macros for pmc_core driver Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:perf/core] x86/pmc_core: Use Intel family name macros for pmc_core driver tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 19/20] x86, rapl: add Skylake server model detection Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:perf/core] perf/x86/rapl: Add Skylake server model detection tip-bot for Jacob Pan <tipbot@zytor.com> - 2016-06-08 13:10 +0200
Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model detection Vince Weaver <vincent.weaver@maine.edu> - 2016-06-08 16:20 +0200
Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model detection Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-06-10 14:40 +0200
Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model detection Dave Hansen <dave@sr71.net> - 2016-06-10 17:50 +0200
[PATCH 18/20] x86, thermal: clean up and fix cpu model detection for intel_soc_dts_thermal Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86, thermal: Clean up and fix CPU model detection for intel_soc_dts_thermal tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
[PATCH 15/20] x86, intel_telemetry: use Intel family name macros for telemetry driver Dave Hansen <dave@sr71.net> - 2016-06-03 02:30 +0200
[tip:x86/cpu] x86/intel_telemetry: Use Intel family name macros for telemetry driver tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 16:20 +0200
Re: [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-03 02:40 +0200
[tip:x86/urgent] x86/cpu/intel: Introduce macros for Intel family numbers tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 12:00 +0200
[tip:x86/urgent] x86/cpu/intel: Introduce macros for Intel family numbers tip-bot for Dave Hansen <tipbot@zytor.com> - 2016-06-08 12:10 +0200
Re: [PATCH 01/20] [v2] x86, intel: Introduce macros for Intel family numbers Ingo Molnar <mingo@kernel.org> - 2016-06-08 13:10 +0200
csiph-web