Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417333

Re: [PATCH] arm64: mm: only initialize swiotlb when necessary

Show all headers | View raw

On Wed, Jun 08, 2016 at 03:53:46PM +0800, Jisheng Zhang wrote:
>  static int __init arm64_dma_init(void)
>  {
> +	if (swiotlb_force || max_pfn > (arm64_dma_phys_limit >> PAGE_SHIFT))
> +		swiotlb = 1;
> +
>  	return atomic_pool_init();
>  }

So any platform with RAM larger than 4GB would still initialise swiotlb.
I wouldn't say it's an issue, 64MB is not a significant loss on such
systems.

An alternative would be to defer the freeing until we are aware of all
possible dma masks for the populated devices (e.g. from DT), though I'm
not sure that's enough, drivers may try to change such masks when
probed.

-- 
Catalin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64: mm: only initialize swiotlb when necessary Jisheng Zhang <jszhang@marvell.com> - 2016-06-08 10:00 +0200
  Re: [PATCH] arm64: mm: only initialize swiotlb when necessary Jisheng Zhang <jszhang@marvell.com> - 2016-06-08 10:10 +0200
  Re: [PATCH] arm64: mm: only initialize swiotlb when necessary Catalin Marinas <catalin.marinas@arm.com> - 2016-06-08 14:10 +0200
    Re: [PATCH] arm64: mm: only initialize swiotlb when necessary Arnd Bergmann <arnd@arndb.de> - 2016-06-08 17:50 +0200
  Re: [PATCH] arm64: mm: only initialize swiotlb when necessary Catalin Marinas <catalin.marinas@arm.com> - 2016-06-08 14:20 +0200

csiph-web