Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message

From	Peter Griffin <peter.griffin@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message
Date	2016-06-08 10:50 +0200
Message-ID	<rHHlv-6ig-3@gated-at.bofh.it> (permalink)
References	<rHtse-5IE-7@gated-at.bofh.it> <rHu4V-6bp-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Baruch,

On Tue, 07 Jun 2016, Baruch Siach wrote:

> Hi Peter,
> 
> On Tue, Jun 07, 2016 at 06:50:09PM +0100, Peter Griffin wrote:
> > kzalloc will issue its own error message including a dump_stack()
> > so remote the site specific message.
> > 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  drivers/phy/phy-qcom-ufs-qmp-14nm.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/phy/phy-qcom-ufs-qmp-14nm.c b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > index 56631e7..958e9cc 100644
> > --- a/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > +++ b/drivers/phy/phy-qcom-ufs-qmp-14nm.c
> > @@ -139,11 +139,9 @@ static int ufs_qcom_phy_qmp_14nm_probe(struct platform_device *pdev)
> >  	int err = 0;
> >  
> >  	phy = devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL);
> > -	if (!phy) {
> > -		dev_err(dev, "%s: failed to allocate phy\n", __func__);
> > +	if (!phy)
> >  		err = -ENOMEM;
> >  		goto out;
> > -	}
> 
> Are you sure? The 'goto' is now unconditional.

Your correct... that is not what I intended to do! Will send a v2.

regards,

Peter.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM error message Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 20:00 +0200
  [PATCH 2/2] phy: phy-qcom-ufs-qmp-20nm: Remove site specific OOM error message Peter Griffin <peter.griffin@linaro.org> - 2016-06-07 20:00 +0200
  Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM  error message Baruch Siach <baruch@tkos.co.il> - 2016-06-07 20:40 +0200
    Re: [PATCH 1/2] phy: phy-qcom-ufs-qmp-14nm: Remove site specific OOM  error message Peter Griffin <peter.griffin@linaro.org> - 2016-06-08 10:50 +0200

csiph-web