Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code

From	Magnus Damm <magnus.damm@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code
Date	2016-06-08 11:20 +0200
Message-ID	<rHHOx-6Iz-5@gated-at.bofh.it> (permalink)
References	<rHgbD-5Lh-3@gated-at.bofh.it> <rHznX-1aY-13@gated-at.bofh.it> <rHFMK-5qw-17@gated-at.bofh.it> <rHHlw-6ig-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Laurent,

On Wed, Jun 8, 2016 at 5:48 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Geert,
>
> On Wednesday 08 Jun 2016 09:04:17 Geert Uytterhoeven wrote:
>> On Wed, Jun 8, 2016 at 2:18 AM, Laurent Pinchart wrote:
>> >> --- 0031/drivers/iommu/ipmmu-vmsa.c
>> >> +++ work/drivers/iommu/ipmmu-vmsa.c   2016-06-06 11:19:40.210607110 +0900
>> >> @@ -1074,7 +1074,7 @@ static const struct ipmmu_features ipmmu
>> >>       .twobit_imttbcr_sl0 = false,
>  >>  };
>> >>
>> >> -static const struct ipmmu_features ipmmu_features_r8a7795 = {
>> >> +static const struct ipmmu_features ipmmu_features_rcar_gen3 = {
>> >>       .use_ns_alias_offset = false,
>> >>       .has_cache_leaf_nodes = true,
>> >>       .has_eight_ctx = true,
>> >> @@ -1088,7 +1088,10 @@ static const struct of_device_id ipmmu_o
>> >>               .data = &ipmmu_features_default,
>> >>       }, {
>> >>               .compatible = "renesas,ipmmu-r8a7795",
>> >> -             .data = &ipmmu_features_r8a7795,
>> >> +             .data = &ipmmu_features_rcar_gen3,
>> >> +     }, {
>> >> +             .compatible = "renesas,ipmmu-r8a7796",
>> >> +             .data = &ipmmu_features_rcar_gen3,
>> >>       }, {
>> >>               /* Terminator */
>> >>       },
>> >> @@ -1268,6 +1271,8 @@ IOMMU_OF_DECLARE(ipmmu_vmsa_iommu_of, "r
>> >>                ipmmu_vmsa_iommu_of_setup);
>> >>  IOMMU_OF_DECLARE(ipmmu_r8a7795_iommu_of, "renesas,ipmmu-r8a7795",
>> >>                ipmmu_vmsa_iommu_of_setup);
>> >> +IOMMU_OF_DECLARE(ipmmu_r8a7796_iommu_of, "renesas,ipmmu-r8a7796",
>> >> +              ipmmu_vmsa_iommu_of_setup);
>> >
>> > How about a Gen3 generic compatible string in addition to the SoC-specific
>> > ones ?
>>
>> Do we want to specify the number of utlbs here?
>> Does it differ between r8a7795, r8a7796, and future members?
>
> It differs between IPMMU instances on a given SoC, so if we want to specify it
> it should be a DT property.

Can you please point out which documentation that says it varies with
IPMMU instance?

Based on IMUCTRn register description "H3-ES1" has 0-31 range while
"Others" have 0-47.

Thanks,

/ magnus

Thread

[PATCH 0/3] iommu/ipmmu-vmsa: Initial r8a7796 support Magnus Damm <magnus.damm@gmail.com> - 2016-06-07 05:50 +0200
  [PATCH 1/3] iommu/ipmmu-vmsa: Add r8a7796 DT binding Magnus Damm <magnus.damm@gmail.com> - 2016-06-07 05:50 +0200
    Re: [PATCH 1/3] iommu/ipmmu-vmsa: Add r8a7796 DT binding Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-08 02:20 +0200
  [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Magnus Damm <magnus.damm@gmail.com> - 2016-06-07 06:00 +0200
    Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-08 02:20 +0200
      Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-08 09:10 +0200
        Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Magnus Damm <magnus.damm@gmail.com> - 2016-06-08 10:10 +0200
        Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-08 10:50 +0200
          Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Magnus Damm <magnus.damm@gmail.com> - 2016-06-08 11:20 +0200
      Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Magnus Damm <magnus.damm@gmail.com> - 2016-06-08 10:10 +0200
  [PATCH 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48 Magnus Damm <magnus.damm@gmail.com> - 2016-06-07 06:00 +0200
    Re: [PATCH 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-06-07 13:10 +0200
    Re: [PATCH 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48 Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-06-08 02:20 +0200
  Re: [PATCH 0/3] iommu/ipmmu-vmsa: Initial r8a7796 support Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-07 09:40 +0200

csiph-web