Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1417047

Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue

From Ido Schimmel <idosch@mellanox.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue
Date 2016-06-08 10:30 +0200
Message-ID <rHH29-6b9-13@gated-at.bofh.it> (permalink)
References <rHvkl-6Ti-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Tue, Jun 07, 2016 at 10:59:46PM IDT, bhaktipriya96@gmail.com wrote:
>alloc_workqueue replaces deprecated create_workqueue().
>
>A dedicated workqueue has been used since the workqueue
>mlxsw_wq is used for FDB notif. processing with workitems that are
>involved in normal device operation && because it's a network device
>which can be depended upon during memory reclaim.
>
>Workitems &trans->timeout_dw and &mlxsw_sp->fdb_notify.dw,
>map to mlxsw_sp_fdb_notify_work (processes FDB notifications from the
>underlying device and resolves the netdev to which the entry points to
>and notifies the bridge using the switchdev notifier) and
>mlxsw_emad_trans_timeout_work (provides async EMAD register access)
>respectively.

The ordering here is off - timeout_dw is for
mlxsw_emad_trans_timeout_work() and fdb_notify.dw is for
mlxsw_sp_fdb_notify_work(), but otherwise this seems fine to me.

Tested-by: Ido Schimmel <idosch@mellanox.com>

Thanks!

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mlxsw: core: Remove deprecated create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-07 22:00 +0200
  Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue Jiri Pirko <jiri@resnulli.us> - 2016-06-08 10:00 +0200
  Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue Ido Schimmel <idosch@mellanox.com> - 2016-06-08 10:30 +0200
  Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue David Miller <davem@davemloft.net> - 2016-06-10 09:00 +0200

csiph-web