Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture parameters to devicetree

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture parameters to devicetree
Date	2016-06-08 09:40 +0200
Message-ID	<rHGfM-5Ap-39@gated-at.bofh.it> (permalink)
References	<rG2kq-6QU-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 3, 2016 at 8:40 PM, Andrew Duggan <aduggan@synaptics.com> wrote:

> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>

> +- syna,dribble: Control reporting of dribble packets. Values are 0 for
> +               default, 1 for explicitly disable, 2 for explicitly enable.
> +- syna,palm_detect: Control reporting of the palm detect gesture. Values
> +                       are 0 for default, 1 for explicitly disable, 2 for
> +                       explicitly enable.

I think these belong in the device tree, but you should add four bool
props instead:

syna,dribble-disable;
syna,dribble-enable;
syna,palm-detect-disable;
syna,palm-detect-enable;

Those are way easier for the human authoring the device tree to
cope with than the opaque parameters.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture parameters to devicetree Andrew Duggan <aduggan@synaptics.com> - 2016-06-03 20:50 +0200
  Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture  parameters to devicetree Mark Rutland <mark.rutland@arm.com> - 2016-06-03 21:00 +0200
    Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture  parameters to devicetree Andrew Duggan <aduggan@synaptics.com> - 2016-06-07 21:20 +0200
  Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture  parameters to devicetree Linus Walleij <linus.walleij@linaro.org> - 2016-06-08 09:40 +0200

csiph-web