Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416968

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

Show all headers | View raw

2016-06-08 15:22 GMT+08:00 Ingo Molnar <mingo@kernel.org>:
>
> * Wanpeng Li <kernellwp@gmail.com> wrote:
>
>> From: Wanpeng Li <wanpeng.li@hotmail.com>
>>
>> This patch adds guest steal-time support to full dynticks CPU
>> time accounting. After the following commit:
>>
>> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")
>>
>> ... time sampling became jiffy based, even if it's still listened
>> to ring boundaries, so steal_account_process_tick() is reused
>> to account how many 'ticks' are stolen-time, after the last accumulation.
>
> So the 'ring boundary' part still doesn't parse (neither grammatically nor
> logically) - please rephrase it because I have no idea what you want to say here.

It is original from this slides.
http://ertl.jp/~shinpei/conf/ospert13/slides/FredericWeisbecker.pdf,
slide 28.

>
> Did you want to say:
>
>> ... time sampling became jiffy based, even if it's still being context tracked,
>> so steal_account_process_tick() is reused to account how many 'ticks' are
>> stolen-time, after the last accumulation.
>
> ... which makes sense grammatically but does not make sense to me logically. :-/
>
> Rik, Frederic, could you please help out?
>
> Thanks,
>
>         Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting Wanpeng Li <kernellwp@gmail.com> - 2016-06-08 05:10 +0200
  Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Ingo Molnar <mingo@kernel.org> - 2016-06-08 09:30 +0200
    Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Wanpeng Li <kernellwp@gmail.com> - 2016-06-08 09:30 +0200
      Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Ingo Molnar <mingo@kernel.org> - 2016-06-08 10:00 +0200
        Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Wanpeng Li <kernellwp@gmail.com> - 2016-06-08 10:10 +0200
          Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Wanpeng Li <kernellwp@gmail.com> - 2016-06-08 10:20 +0200
  Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Paolo Bonzini <pbonzini@redhat.com> - 2016-06-08 12:20 +0200
    Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Wanpeng Li <kernellwp@gmail.com> - 2016-06-08 13:20 +0200
  Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Rik van Riel <riel@redhat.com> - 2016-06-08 21:10 +0200
    Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Wanpeng Li <kernellwp@gmail.com> - 2016-06-09 02:00 +0200
      Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full  dynticks CPU time accounting Rik van Riel <riel@redhat.com> - 2016-06-09 03:30 +0200

csiph-web