Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416865

Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device

Show all headers | View raw

On Thu, Jun 02, 2016 at 09:37:28AM +0800, Lu Baolu wrote:
> In some Intel platforms, a single usb port is shared between USB host
> and device controllers. The shared port is under control of a switch
> which is defined in the Intel vendor defined extended capability for
> xHCI.
> 
> This patch adds the support to detect and create the platform device
> for the port mux switch.

Why do you need a platform device for this?  You do nothing with this
device, why create it at all?

And why is it a platform device, isn't is really a PCI device?  Why
would you ever find a "platform" device below a PCI device?  Don't abuse
platform devices for things that aren't.  It makes me want to delete
that whole interface more and more...

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu <baolu.lu@linux.intel.com> - 2016-06-02 03:40 +0200
  Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-08 06:50 +0200
    Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu <baolu.lu@linux.intel.com> - 2016-06-08 10:00 +0200
      Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-06-08 17:50 +0200
        Re: [PATCH v10 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu <baolu.lu@linux.intel.com> - 2016-06-09 04:40 +0200

csiph-web