Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1416852
| From | Garlic Tseng <garlic.tseng@mediatek.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation. |
| Date | 2016-06-08 05:40 +0200 |
| Message-ID | <rHCvw-365-7@gated-at.bofh.it> (permalink) |
| References | <rFPnb-76D-3@gated-at.bofh.it> <rFPnc-76D-31@gated-at.bofh.it> <rHscN-51h-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote:
> On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote:
>
> > + if (val < 0 || val > MT2701_I2S_NUM) {
> > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n",
> > + __func__, num, val);
> > + return -1;
>
> Real error codes please.
OK I'll fix it.
>
> > +static const struct snd_kcontrol_new mt2701_afe_multi_ch_out_asrc3[] = {
> > + SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1,
> > + 1),
> > +};
>
> On/off controls should end in Switch.
Do you means that the name should end in Switch? Something like "Multi
ch asrc out3 Switch" (or maybe a shorter one)
I'll fix it (if I don't misunderstand the comment)
Thanks!
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[alsa-devel] [PATCH v2 0/9] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-03 07:00 +0200
[alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-03 07:00 +0200
Re: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701 Mark Brown <broonie@kernel.org> - 2016-06-07 18:20 +0200
Re: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-08 03:50 +0200
[alsa-devel] [PATCH v2 3/9] ASoC: mediatek: let mt8173 use mediatek common structure Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-03 07:00 +0200
[alsa-devel] [PATCH v2 7/9] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-03 07:00 +0200
[alsa-devel] [PATCH v2 4/9] ASoC: mediatek: add documents for mt2701 Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-03 07:00 +0200
Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation. Mark Brown <broonie@kernel.org> - 2016-06-07 18:40 +0200
Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation. Garlic Tseng <garlic.tseng@mediatek.com> - 2016-06-08 05:40 +0200
Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation. Mark Brown <broonie@kernel.org> - 2016-06-09 12:50 +0200
csiph-web