Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group
Date	2016-06-08 04:20 +0200
Message-ID	<rHBg5-2r1-3@gated-at.bofh.it> (permalink)
References	<rGXVo-2jv-5@gated-at.bofh.it> <rGXVo-2jv-23@gated-at.bofh.it> <rH1Z0-4WZ-25@gated-at.bofh.it> <rHfyV-5wp-3@gated-at.bofh.it> <rHkff-6M-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 07, 2016 at 10:09:14AM +0200, Vincent Guittot wrote:
> >> A much more simple solution would be
> >> to prevent last_update_time to be initialized with this special value.
> >> We can initialize the last_update_time of a sched_entity to 1 as an
> >> example which is easier than these changes.
> >
> > Then at least, we must differentiate CONFIG_FAIR_GROUP_SCHED and
> > !CONFIG_FAIR_GROUP_SCHED. And I am not sure whether this is a simpler
> 
> Why do you want to differentiate ? we already have
> sa->last_update_time = 0; in init_entity_runnable_average. We just
> have to change it by sa->last_update_time = 1;

If !CONFIG_FAIR_GROUP_SCHED, we don't have task_move_group_fair().
If last_update_time != 0, we won't attach it for new task. Correct?

Thread

[PATCH v4 0/5] sched/fair: Fix attach and detach sched avgs for task group change or sched class change Yuyang Du <yuyang.du@intel.com> - 2016-06-06 10:20 +0200
  [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group Yuyang Du <yuyang.du@intel.com> - 2016-06-06 10:20 +0200
    Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice  when switching to fair or changing task group Peter Zijlstra <peterz@infradead.org> - 2016-06-06 12:00 +0200
      Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice  when switching to fair or changing task group Yuyang Du <yuyang.du@intel.com> - 2016-06-07 05:40 +0200
    Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice  when switching to fair or changing task group Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-06 14:40 +0200
      Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice  when switching to fair or changing task group Yuyang Du <yuyang.du@intel.com> - 2016-06-07 05:10 +0200
        Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice  when switching to fair or changing task group Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-07 10:10 +0200
          Re: [PATCH v4 2/5] sched/fair: Fix attaching task sched avgs twice  when switching to fair or changing task group Yuyang Du <yuyang.du@intel.com> - 2016-06-08 04:20 +0200
  [PATCH v4 5/5] sched/fair: Add inline to detach_entity_load_evg() Yuyang Du <yuyang.du@intel.com> - 2016-06-06 10:20 +0200
  [PATCH v4 4/5] sched/fair: Move load and util avgs from wake_up_new_task() to sched_fork() Yuyang Du <yuyang.du@intel.com> - 2016-06-06 10:20 +0200
  [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg() Yuyang Du <yuyang.du@intel.com> - 2016-06-06 10:20 +0200
    Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg() Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-06 15:40 +0200
      Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg() Vincent Guittot <vincent.guittot@linaro.org> - 2016-06-06 15:50 +0200
        Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg() Matt Fleming <matt@codeblueprint.co.uk> - 2016-06-06 16:10 +0200
        Re: [PATCH v4 1/5] sched/fair: Clean up attach_entity_load_avg() Peter Zijlstra <peterz@infradead.org> - 2016-06-06 16:30 +0200

csiph-web