Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415427

Re: undefined reference to `early_panic'

Show all headers | View raw

On Sun, 5 Jun 2016 12:33:29 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:

> It's probably a bug fix that unveils the link errors.
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   049ec1b5a76d34a6980cccdb7c0baeb4eed7a993
> commit: 888cdbc2c9a76a0e450f533b1957cdbfe7d483d5 hugetlb: fix compile error on tile
> date:   5 months ago
> config: tile-allnoconfig (attached as .config)
> compiler: tilegx-linux-gcc (GCC) 4.6.2
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 888cdbc2c9a76a0e450f533b1957cdbfe7d483d5
>         # save the attached .config to linux build tree
>         make.cross ARCH=tile 
> 
> All errors (new ones prefixed by >>):
> 
>    arch/tile/built-in.o: In function `setup_arch':
> >> (.init.text+0x15d8): undefined reference to `early_panic'
>    arch/tile/built-in.o: In function `setup_arch':
>    (.init.text+0x1610): undefined reference to `early_panic'
>    arch/tile/built-in.o: In function `setup_arch':
>    (.init.text+0x1800): undefined reference to `early_panic'
>    arch/tile/built-in.o: In function `setup_arch':
>    (.init.text+0x1828): undefined reference to `early_panic'
>    arch/tile/built-in.o: In function `setup_arch':
>    (.init.text+0x1bd8): undefined reference to `early_panic'
>    arch/tile/built-in.o:(.init.text+0x1c18): more undefined references to `early_panic' follow

This?

From: Andrew Morton <akpm@linux-foundation.org>
Subject: tile: early_printk.o is always required

arch/tile/setup.o is always compiled, and it requires early_panic() and
hence early_printk(), so we must always build and link early_printk.o.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/tile/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -puN arch/tile/Kconfig~tile-early_printko-is-always-required arch/tile/Kconfig
--- a/arch/tile/Kconfig~tile-early_printko-is-always-required
+++ a/arch/tile/Kconfig
@@ -14,6 +14,7 @@ config TILE
 	select GENERIC_FIND_FIRST_BIT
 	select GENERIC_IRQ_PROBE
 	select GENERIC_IRQ_SHOW
+	select EARLY_PRINTK
 	select GENERIC_PENDING_IRQ if SMP
 	select GENERIC_STRNCPY_FROM_USER
 	select GENERIC_STRNLEN_USER
_

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

undefined reference to `early_panic' kbuild test robot <fengguang.wu@intel.com> - 2016-06-05 06:50 +0200
  Re: undefined reference to `early_panic' Andrew Morton <akpm@linux-foundation.org> - 2016-06-06 22:40 +0200
    Re: undefined reference to `early_panic' Stephen Rothwell <sfr@canb.auug.org.au> - 2016-06-07 01:40 +0200
    Re: tile: early_printk.o is always required kbuild test robot <lkp@intel.com> - 2016-06-07 11:20 +0200
      Re: tile: early_printk.o is always required Andrew Morton <akpm@linux-foundation.org> - 2016-06-07 22:00 +0200

csiph-web