[RFC PATCH 2/2] xfs: map KM_MAYFAIL to __GFP_RETRY_HARD

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	[RFC PATCH 2/2] xfs: map KM_MAYFAIL to __GFP_RETRY_HARD
Date	2016-06-06 13:40 +0200
Message-ID	<rH12W-4it-13@gated-at.bofh.it> (permalink)
References	<rH12W-4it-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

KM_MAYFAIL didn't have any suitable GFP_FOO counterpart until recently
so it relied on the default page allocator behavior for the given set
of flags. This means that small allocations actually never failed.

Now that we have __GFP_RETRY_HARD flags which works independently on the
allocation request size we can map KM_MAYFAIL to it. The allocator will
try as hard as it can to fulfill the request but fails eventually if
the progress cannot be made.

Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 fs/xfs/kmem.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/xfs/kmem.h b/fs/xfs/kmem.h
index 689f746224e7..34e6b062ce0e 100644
--- a/fs/xfs/kmem.h
+++ b/fs/xfs/kmem.h
@@ -54,6 +54,9 @@ kmem_flags_convert(xfs_km_flags_t flags)
 			lflags &= ~__GFP_FS;
 	}
 
+	if (flags & KM_MAYFAIL)
+		lflags |= __GFP_RETRY_HARD;
+
 	if (flags & KM_ZERO)
 		lflags |= __GFP_ZERO;
 
-- 
2.8.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/2] mm: give GFP_REPEAT a better semantic Michal Hocko <mhocko@kernel.org> - 2016-06-06 13:40 +0200
  [RFC PATCH 2/2] xfs: map KM_MAYFAIL to __GFP_RETRY_HARD Michal Hocko <mhocko@kernel.org> - 2016-06-06 13:40 +0200

csiph-web