[PATCH] rxrpc: fix ptr_ret.cocci warnings

From	kbuild test robot <fengguang.wu@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] rxrpc: fix ptr_ret.cocci warnings
Date	2016-06-05 01:20 +0200
Message-ID	<rGt1f-7iX-3@gated-at.bofh.it> (permalink)
References	<rGt1f-7iX-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

net/rxrpc/rxkad.c:1165:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: David Howells <dhowells@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 rxkad.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -1162,9 +1162,7 @@ static int rxkad_init(void)
 	/* pin the cipher we need so that the crypto layer doesn't invoke
 	 * keventd to go get it */
 	rxkad_ci = crypto_alloc_skcipher("pcbc(fcrypt)", 0, CRYPTO_ALG_ASYNC);
-	if (IS_ERR(rxkad_ci))
-		return PTR_ERR(rxkad_ci);
-	return 0;
+	return PTR_ERR_OR_ZERO(rxkad_ci);
 }
 
 /*

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] rxrpc: fix ptr_ret.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2016-06-05 01:20 +0200
  Re: [PATCH] rxrpc: fix ptr_ret.cocci warnings David Miller <davem@davemloft.net> - 2016-06-08 00:40 +0200
  Re: [PATCH] rxrpc: fix ptr_ret.cocci warnings David Howells <dhowells@redhat.com> - 2016-06-09 16:40 +0200

csiph-web