Re: [PATCH 1/3] fs: befs: Lookup must return error code only on real error

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] fs: befs: Lookup must return error code only on real error
Date	2016-06-04 21:40 +0200
Message-ID	<rGpAl-57V-3@gated-at.bofh.it> (permalink)
References	<rGoXD-4Gb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jun 04, 2016 at 07:53:19PM +0100, Salah Triki wrote:
> File not found is not an error and lookup must return error code only
> on real error, otherwise creating inodes with functions like create,
> mkdir and so on will fail.

You do realize that befs is read-only and doesn't have ->mkdir() and friends,
right?  Patch is almost correct (you want d_add(dentry, NULL) if you go
that way, or you'll be calling ->lookup() ever time anyway), but it doesn't
make much sense on its own.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] fs: befs: Lookup must return error code only on real error Salah Triki <salah.triki@acm.org> - 2016-06-04 21:00 +0200
  [PATCH 3/3] fs: befs: Increment i_count when inode is found Salah Triki <salah.triki@acm.org> - 2016-06-04 21:00 +0200
    Re: [PATCH 3/3] fs: befs: Increment i_count when inode is found kbuild test robot <lkp@intel.com> - 2016-06-04 21:20 +0200
    Re: [PATCH 3/3] fs: befs: Increment i_count when inode is found Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-04 21:40 +0200
      Re: [PATCH 3/3] fs: befs: Increment i_count when inode is found Salah Triki <salah.triki@acm.org> - 2016-06-04 22:10 +0200
  [PATCH 2/3] fs: befs: Insert NULL inode to dentry Salah Triki <salah.triki@acm.org> - 2016-06-04 21:00 +0200
  Re: [PATCH 1/3] fs: befs: Lookup must return error code only on real  error Al Viro <viro@ZenIV.linux.org.uk> - 2016-06-04 21:40 +0200

csiph-web