Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1413792
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] char: Prefer pr_* instead of printk |
| Date | 2016-06-04 18:40 +0200 |
| Message-ID | <rGmM9-3qZ-13@gated-at.bofh.it> (permalink) |
| References | <rGl3H-2ms-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Jun 04, 2016 at 08:15:11PM +0530, Jyoti Singh wrote: > This patch replaces all the printk[KERN_INFO] with pr_* in the file > "ttyprintk.c" addressing the following warning: > > WARNING:Prefer [subsystem eg: netdev]_info([subsystem]dev, ... > then dev_info(dev,... then pr_info(... to printk(KERN_INFO ... > Found with checkpatch Sometimes checkpatch tells you to do things that are incorrect :) Are you _sure_ the code works the same before and after this? The ttyprintk driver is a bit "special". Did you test these changes? thanks, greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] char: Prefer pr_* instead of printk Jyoti Singh <jssengar92@gmail.com> - 2016-06-04 16:50 +0200
Re: [PATCH] char: Prefer pr_* instead of printk Greg KH <gregkh@linuxfoundation.org> - 2016-06-04 18:40 +0200
Re: [PATCH] char: Prefer pr_* instead of printk jyoti singh <jssengar92@gmail.com> - 2016-06-06 08:20 +0200
Re: [PATCH] char: Prefer pr_* instead of printk Greg KH <gregkh@linuxfoundation.org> - 2016-06-06 16:40 +0200
Re: [PATCH] char: Prefer pr_* instead of printk Joe Perches <joe@perches.com> - 2016-06-06 17:30 +0200
csiph-web