Re: [PATCH 6/6] x86/signal: add SA_{X32,IA32}_ABI sa_flags

From	Dmitry Safonov <0x7f454c46@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] x86/signal: add SA_{X32,IA32}_ABI sa_flags
Date	2016-06-04 18:00 +0200
Message-ID	<rGm9r-2YU-3@gated-at.bofh.it> (permalink)
References	<rFedX-qG-13@gated-at.bofh.it> <rFedX-qG-11@gated-at.bofh.it> <rGc0p-4AW-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-06-04 8:08 GMT+03:00 Andy Lutomirski <luto@amacapital.net>:
> On Jun 1, 2016 6:13 AM, "Dmitry Safonov" <dsafonov@virtuozzo.com> wrote:

>> --- a/arch/x86/include/uapi/asm/signal.h
>> +++ b/arch/x86/include/uapi/asm/signal.h
>> @@ -70,6 +70,8 @@ typedef unsigned long sigset_t;
>>   * SA_RESETHAND clears the handler when the signal is delivered.
>>   * SA_NOCLDWAIT flag on SIGCHLD to inhibit zombies.
>>   * SA_NODEFER prevents the current signal from being masked in the handler.
>> + * SA_IA32_ABI/SA_X32_ABI indicates ABI for a signal frame,
>> + *   if neither is set, the kernel will set them according to a syscall ABI
>
> I would prefer if these weren't in the UAPI header.  If you want a
> foreign signal frame type, do a foreign syscall.  This also means that
> you should strip these flags if a user sets them directly.

Oh, thanks Andy!
I remember you have said it to the previous RFC.
So I did it -- please, check sigaction_compat_abi().
It seems like, I forget to correct this comment accordingly (will do to v2).
Shouldn't I mark in uapi header that those flag bits are reserved,
defining them there?

-- 
Regards,
Safonov Dmitry.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] x86/signal: add SA_{X32,IA32}_ABI sa_flags Dmitry Safonov <dsafonov@virtuozzo.com> - 2016-06-01 15:20 +0200
  Re: [PATCH 6/6] x86/signal: add SA_{X32,IA32}_ABI sa_flags Andy Lutomirski <luto@amacapital.net> - 2016-06-04 07:10 +0200
    Re: [PATCH 6/6] x86/signal: add SA_{X32,IA32}_ABI sa_flags Dmitry Safonov <0x7f454c46@gmail.com> - 2016-06-04 18:00 +0200

csiph-web