Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue

From	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue
Date	2016-06-04 16:10 +0200
Message-ID	<rGkr2-29V-83@gated-at.bofh.it> (permalink)
References	<rFxgC-4bE-15@gated-at.bofh.it> <rFKGR-490-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thank you for your feedback.
Will send another patch with changed description.

Bhaktipriya.


On Fri, Jun 3, 2016 at 5:25 AM, Izumi, Taku <izumi.taku@jp.fujitsu.com> wrote:
> Dear Bhaktipriya,
>
> Thanks. Looks good to me.
>
> Sincerely,
> Taku Izumi
>
>> -----Original Message-----
>> From: Bhaktipriya Shridhar [mailto:bhaktipriya96@gmail.com]
>> Sent: Thursday, June 02, 2016 6:31 PM
>> To: David S. Miller; Izumi, Taku/泉 拓; Florian Westphal; Bhaktipriya Shridhar
>> Cc: Tejun Heo; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] net: fjes: fjes_main: Remove create_workqueue
>>
>> alloc_workqueue replaces deprecated create_workqueue().
>>
>> The workqueue adapter->txrx_wq has workitem
>> &adapter->raise_intr_rxdata_task per adapter. Extended Socket Network
>> Device is shared memory based, so someone's transmission denotes other's
>> reception.  raise_intr_rxdata_task raises interruption of receivers from
>> the sender in order to notify receivers.
>>
>> The workqueue adapter->control_wq has workitem
>> &adapter->interrupt_watch_task per adapter. interrupt_watch_task is used
>> to prevent delay of interrupts.
>>
>> Dedicated workqueues have been used in both cases since the workitems
>> on the workqueues are involved in normal device operation and require
>> forward progress under memory pressure.
>>
>> max_active has been set to 0 since there is no need for throttling
>> the number of active work items.
>>
>> Since network devices  may be used for memory reclaim,
>> WQ_MEM_RECLAIM has been set to guarantee forward progress.
>>
>> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
>> ---
>>  drivers/net/fjes/fjes_main.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
>> index 86c331b..9006877 100644
>> --- a/drivers/net/fjes/fjes_main.c
>> +++ b/drivers/net/fjes/fjes_main.c
>> @@ -1187,8 +1187,9 @@ static int fjes_probe(struct platform_device *plat_dev)
>>       adapter->force_reset = false;
>>       adapter->open_guard = false;
>>
>> -     adapter->txrx_wq = create_workqueue(DRV_NAME "/txrx");
>> -     adapter->control_wq = create_workqueue(DRV_NAME "/control");
>> +     adapter->txrx_wq = alloc_workqueue(DRV_NAME "/txrx", WQ_MEM_RECLAIM, 0);
>> +     adapter->control_wq = alloc_workqueue(DRV_NAME "/control",
>> +                                           WQ_MEM_RECLAIM, 0);
>>
>>       INIT_WORK(&adapter->tx_stall_task, fjes_tx_stall_task);
>>       INIT_WORK(&adapter->raise_intr_rxdata_task,
>> --
>> 2.1.4
>>
>

Thread

[PATCH] net: fjes: fjes_main: Remove create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-02 11:40 +0200
  Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-02 17:00 +0200
  RE: [PATCH] net: fjes: fjes_main: Remove create_workqueue "Izumi, Taku" <izumi.taku@jp.fujitsu.com> - 2016-06-03 02:00 +0200
    Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-04 16:10 +0200
      Re: [PATCH] net: fjes: fjes_main: Remove create_workqueue David Miller <davem@davemloft.net> - 2016-06-04 21:40 +0200

csiph-web