Re: [PATCH 5/5] intel_idle: Add S0ix validation

From	Alan <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] intel_idle: Add S0ix validation
Date	2016-06-04 14:30 +0200
Message-ID	<rGiSe-A9-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <rFx6W-48t-25@gated-at.bofh.it> <rFARc-6rl-21@gated-at.bofh.it> <rFG0x-1gi-7@gated-at.bofh.it> <rFGWB-1T8-7@gated-at.bofh.it> <rFHzk-2l4-27@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

> I would expect those IP blocks to do nothing and not block lower power
> states if the firmware is not loaded. If that is not the case, I think
> that should be fixed such that those lower power states are at least
> available during suspend (if not during runtime). If your Skylake+
> system is not entering S0ix during freeze, I consider that a bug that
> needs to be addressed.

You would assume wrongly. Several parts of the system do their own
power management so if present need to have a driver loaded. Graphics
is the example everyone is familiar with but ADSP audio and ISH are two
others.

> configs, that's their decision. As I said, this does nothing in the
> !CONFIG_INTEL_PMC_CORE case, but if a finer level config is warranted,
> I can add that.

IMHO it belongs as a config item because it has a power cost, and you
can't turn it off without enabling debugfs when it's compiled in.

> I would prefer if others used this more, since there would be better
> debug coverage and I would have to fix fewer bugs.

I'd be more concerned about getting 10,000 emails bisecting the warning
to your commit 8)

Alan

Thread

[PATCH 5/5] intel_idle: Add S0ix validation dbasehore@chromium.org - 2016-06-02 06:40 +0200
  Re: [PATCH 5/5] intel_idle: Add S0ix validation Peter Zijlstra <peterz@infradead.org> - 2016-06-02 11:30 +0200
    Re: [PATCH 5/5] intel_idle: Add S0ix validation One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-06-02 15:30 +0200
      Re: [PATCH 5/5] intel_idle: Add S0ix validation "dbasehore ." <dbasehore@chromium.org> - 2016-06-02 20:40 +0200
      Re: [PATCH 5/5] intel_idle: Add S0ix validation "dbasehore ." <dbasehore@chromium.org> - 2016-06-02 21:00 +0200
        Re: [PATCH 5/5] intel_idle: Add S0ix validation One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-06-02 22:00 +0200
          Re: [PATCH 5/5] intel_idle: Add S0ix validation "dbasehore ." <dbasehore@chromium.org> - 2016-06-02 22:40 +0200
            Re: [PATCH 5/5] intel_idle: Add S0ix validation Alan <gnomes@lxorguk.ukuu.org.uk> - 2016-06-04 14:30 +0200
              Re: [PATCH 5/5] intel_idle: Add S0ix validation "dbasehore ." <dbasehore@chromium.org> - 2016-06-06 23:40 +0200

csiph-web