Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1414671

Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

Show all headers | View raw

On 05/06/2016 16:56, Andrew Lunn wrote:
> On Sun, Jun 05, 2016 at 08:33:02AM +0200, John Crispin wrote:
>> During stress testing, after reducing the threshold value, we have seen
>> TX timeouts that were caused by the watchdog_timeo value being too low.
>> Increase the value to 5 * HZ which is a value commonly used by many other
>> drivers.
> 
> I've never studied what watchdog_timeo actually means. Does it mean a
> transmit has not completed in that amount of time? Would this imply
> you have 5 seconds worth of packets in your transmit queue? Do you
> know what the driver is doing during this 5 seconds?

Hi Andrew,

it is waiting for the watchdog to trigger :-) TBH the 1s seems to be too
short to for the dma ring length to be flushed and i had to pick some
value and 5 is used most places.

it really depends on the amount of packets in the queue, their length
and the mac setting. the timeout needs to be large enough that it would
not trigger incorrectly even if the mac is on 10mbit half duplex and all
frames in the queue were maximum size.

	John

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] net: mediatek: various small fixes John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
  [PATCH 09/12] net: mediatek: increase watchdog_timeo John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
    Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo Andrew Lunn <andrew@lunn.ch> - 2016-06-05 17:00 +0200
      Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo John Crispin <john@phrozen.org> - 2016-06-06 08:30 +0200
        Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo Andrew Lunn <andrew@lunn.ch> - 2016-06-06 14:30 +0200
          Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo John Crispin <john@phrozen.org> - 2016-06-06 14:40 +0200
  [PATCH 01/12] net: mediatek: fix DQL support John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
    Re: [PATCH 01/12] net: mediatek: fix DQL support David Miller <davem@davemloft.net> - 2016-06-05 09:40 +0200
      Re: [PATCH 01/12] net: mediatek: fix DQL support John Crispin <john@phrozen.org> - 2016-06-06 08:50 +0200
        Re: [PATCH 01/12] net: mediatek: fix DQL support David Miller <davem@davemloft.net> - 2016-06-08 01:10 +0200
          Re: [PATCH 01/12] net: mediatek: fix DQL support Tom Herbert <tom@herbertland.com> - 2016-06-08 01:30 +0200
  [PATCH 07/12] net: mediatek: disable all interrupts during probe John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
  [PATCH 04/12] net: mediatek: invalid buffer lookup in mtk_tx_map() John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
  [PATCH 05/12] net: mediatek: dropped rx packets are not being counted properly John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
  [PATCH 06/12] net: mediatek: add next data pointer coherency protection John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
  [PATCH 08/12] net: mediatek: fix threshold value John Crispin <john@phrozen.org> - 2016-06-05 08:40 +0200
  [PATCH 12/12] net: mediatek: remove superfluous queue wake up call John Crispin <john@phrozen.org> - 2016-06-05 09:10 +0200
  [PATCH 10/12] net: mediatek: fix off by one in the TX ring allocation John Crispin <john@phrozen.org> - 2016-06-05 09:10 +0200
  [PATCH 11/12] net: mediatek: only wake the queue if it is stopped John Crispin <john@phrozen.org> - 2016-06-05 09:10 +0200

csiph-web