Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1414127
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion |
| Date | 2016-06-05 18:40 +0200 |
| Message-ID | <rGJfI-JM-27@gated-at.bofh.it> (permalink) |
| References | <rFU3w-1wB-15@gated-at.bofh.it> <rFUdc-1OZ-41@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 06/03/2016 04:59 AM, Binoy Jayan wrote: > The semaphore 'cmd_queue_sema' is used as completion, > so convert it to struct completion. > > Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org> The subject for this patch has a misplaced "i" at the beginning courtesy of vi. One other point, it is customary to start the patch subject with "staging: rtl8188eu: ..." for drivers in staging. I also prefer using r8188eu rather than rtl8188eu as the former is the actual name of the driver, but either will work. I have tested all 4 of these patches with no problems, thus Acked-by: Larry Finger <Larry.Finger@lwfinger.net> As you may have noted, my testing of the modified driver has resulted in some additional fixes for various problems including a system panic caused by an ill-advised and untested change. Larry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] *** rtl8188eu: Replace semaphores with mutexes or completions *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-03 12:00 +0200
[PATCH 3/4] rtl8188eu: pwrctrl_priv: Replace semaphore 'lock' with mutex Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-03 12:10 +0200
[PATCH 2/4] rtl8188eu: Replace semaphore terminate_cmdthread_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-03 12:10 +0200
[PATCH 4/4] rtl8188eu: Remove unused semaphores Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-03 12:10 +0200
[PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-03 12:10 +0200
Re: [PATCH 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion Larry Finger <Larry.Finger@lwfinger.net> - 2016-06-05 18:40 +0200
Re: [PATCH 0/4] *** rtl8188eu: Replace semaphores with mutexes or completions *** Arnd Bergmann <arnd@arndb.de> - 2016-06-04 12:50 +0200
[PATCH v2 1/4] irtl8188eu: Replace semaphore cmd_queue_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 06:40 +0200
[PATCH v2 0/4] *** rtl8188eu: Replace semaphores with mutexes or completions *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 06:40 +0200
[PATCH v2 2/4] rtl8188eu: Replace semaphore terminate_cmdthread_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 06:40 +0200
[PATCH v2 4/4] rtl8188eu: Remove unused semaphores Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 06:40 +0200
[PATCH v2 3/4] rtl8188eu: pwrctrl_priv: Replace semaphore 'lock' with mutex Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 06:40 +0200
[PATCH v3 0/4] *** staging: r8188eu: Replace semaphores with mutexes or completions *** Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 07:20 +0200
[PATCH v3 1/4] staging: r8188eu: Replace semaphore cmd_queue_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 07:20 +0200
[PATCH v3 3/4] staging: r8188eu: pwrctrl_priv: Replace semaphore 'lock' with mutex Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 07:20 +0200
[PATCH v3 4/4] staging: r8188eu: Remove unused semaphores Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 07:20 +0200
[PATCH v3 2/4] staging: r8188eu: Replace semaphore terminate_cmdthread_sema with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-06-06 07:20 +0200
csiph-web