Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1414112

[PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Fabian Frederick <fabf@skynet.be>
Newsgroups linux.kernel
Subject [PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h
Date Sun, 05 Jun 2016 15:20:02 +0200
Message-ID <rGG8a-7k9-1@gated-at.bofh.it> (permalink)
X-Original-To Nicolin Chen <nicoleotsuka@gmail.com>
X-Belgacom-Dynamic yes
X-Ironport-Anti-Spam-Filtered true
X-Ironport-Anti-Spam-Result A2DXFADBI1RX/0MmtFtcgzqBU7hThAmGEoEbPRABAQEBAQEBZSdBAQEDCwKEIC8jKSZLJBOIM7hzhieOZwWYSI4mAo8cj1o1H4E2AYI5OjKFaVuDbgEBAQ
X-Mailer git-send-email 2.1.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 30
Organization linux.* mail to news gateway
X-Original-Cc alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, fabf@skynet.be
X-Original-Date Sun, 5 Jun 2016 15:11:00 +0200
X-Original-Message-ID <1465132260-6617-1-git-send-email-fabf@skynet.be>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1414112

Show key headers only | View raw


cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled.

sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of
function devm_gpiod_get_optional [-Werror=implicit-function-declaration]
  cs53l30->reset_gpio = devm_gpiod_get_optional(dev, "reset",
  ^
sound/soc/codecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared
(first use in this function)

Including gpio/consumer.h declares minimal functions in that case.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 sound/soc/codecs/cs53l30.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index ac90dd7..4818324 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -15,6 +15,7 @@
 #include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/i2c.h>
+#include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/of_gpio.h>
 #include <linux/regulator/consumer.h>
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h Fabian Frederick <fabf@skynet.be> - 2016-06-05 15:20 +0200
  Re: [PATCH 1/1 linux-next] ASoC: cs53l30: include gpio/consumer.h Nicolin Chen <nicoleotsuka@gmail.com> - 2016-06-06 07:10 +0200

csiph-web