Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413958

[PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups linux.kernel
Subject [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA
Date Sun, 05 Jun 2016 11:50:01 +0200
Message-ID <rGCQV-528-3@gated-at.bofh.it> (permalink)
X-Original-To Greg Kroah-Hartman <gregkh@linuxfoundation.org>
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 31
Organization linux.* mail to news gateway
X-Original-Cc Alan Tull <atull@opensource.altera.com>, Moritz Fischer <moritz.fischer@ettus.com>, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>
X-Original-Date Sun, 5 Jun 2016 11:39:57 +0200
X-Original-Message-ID <1465119597-5461-1-git-send-email-geert@linux-m68k.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1413958

Show key headers only | View raw


If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/fpga/zynq-fpga.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
---
v2:
  - Add Reviewed-by,
  - Updated error message for recent kernels,
  - Submit to Greg, as requested by Alan.
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index c9b9fdf6cfbbeb6d..d61410299ec0cf80 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
 
 config FPGA_MGR_ZYNQ_FPGA
 	tristate "Xilinx Zynq FPGA"
+	depends on HAS_DMA
 	help
 	  FPGA manager driver support for Xilinx Zynq FPGAs.
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-06-05 11:50 +0200
  Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA Moritz Fischer <moritz.fischer@ettus.com> - 2016-06-06 22:40 +0200

csiph-web